[AutoPR @azure/arm-authorization] Exposing reviewers property on accessReviewInstance model #5658
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![openapi-sdkautomation[bot]](https://avatars.githubusercontent.com/in/10463?s=60&v=4){kind=small}
26 tasks
Merge 585055674324f39b8cfabeb9bec58c5130705227 into 444d527ca9ba163e65ad4ce9fc888a6f69940a4c
openapi-sdkautomation
bot
force-pushed
the
sdkAuto/14560/@azure_arm-authorization
branch
from
06b5b83
to
a6adb52
Compare
openapi-sdkautomation bot
pushed a commit
that referenced
this pull request
Feb 1, 2022
[Hub Generated] Public private branch 'dev-digitaltwins-Microsoft.DigitalTwins-2021-06-30-preview-merge-with-main' (Azure#17186) * Adds base for updating Microsoft.DigitalTwins from version stable/2020-12-01 to version 2021-06-30-preview * Updates readme * Updates API version in new specs and examples * Add RM API Version Microsoft.DigitalTwins 2021-06-30-preview (#3404) * Add SDK Generation Options for new API Version (#3179) * Add SDK generation for 2021-06-30-preview * The following fixes were done: * Fixed schema location: preview instead of stable * Updated go SDK generation to point to preview namespace * Remove Ruby support * add SystemData and update instance and endpoints definitions * added systemdata to all examples * fix typo * fix prettier issues * added experimental operations fix * fixed some errors * addressed lint and model errors * fixed type issues with endpoints examples * Fixed autorest error * removed unnecessary _allOf_s * Add Time Series Database Connection Resource and CRUD API Endpoints (#3180) * Added basic time series integration resource CRUD and resource description * Add list call for TSDB integration resources * Modify naming for adx endpoint * Rename document names and paths from integration resources to time series database connections; also clean up descriptions, and make more specific to time series database connections (rather than general integrations) * Update operation names * Resolve review comments * Add examples for time series database connection CRUD * Add example for missing status code 200 to DELETE * Run prettier and fix formatting issues * Align tags, solve issue in Python SDK generation * Align python readme * Fix linter error * Fix linter error 2 * Fix linter error * Made privateEndpointConnections readonly, added additional documentation for keybased and entitybased authenticationType (#3358) * Address major lintdiff warnings * Fix more linter warnings * Address remaining lintdiff warnings and errors * Remove property flattening to avoid issues with polymorphism, edit suppression directives to point to new location * Address lintdiff error * Add systemData property to private endpoint connection resource * Address breaking change warnings * Fix inheritance * Update suppressions to point to new locations in document * Updated TSDB connection parameter set * Fix issue in property set * Revert readOnly=true from private endpoint connections property * Revert change to TopicEndpoint * Back to camelcase... * Revert change in old API version * Revert TopicEndpoint back to camelCase * Revert allOf addition * Change capitalization of TopicEndpoint back to original from previous version * Add approved suppression * Fix $.definitions path in suppression rules Co-authored-by: Nate Lehman <nalehman@microsoft.com> Co-authored-by: Nate Lehman <njlehman1@gmail.com> * Align with repo (#5658) Co-authored-by: Nate Lehman <nalehman@microsoft.com> Co-authored-by: Nate Lehman <njlehman1@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create to sync Azure/azure-rest-api-specs#14560
Installation Instructions
You can install the package
@azure/arm-authorizationof this PR using the following command:curl -L "https://portal.azure-devex-tools.com/api/sdk-dl-pub?p=Azure/14560/azure-sdk-for-js/@azure_arm-authorization/azure-arm-authorization-8.4.0.tgz" -o azure-arm-authorization-8.4.0.tgz npm install azure-arm-authorization-8.4.0.tgzDirect Download
The generated package can be directly downloaded from here: