Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[INQUIRY] 문의하기 UI 수정 #109

Merged
merged 51 commits into from
Nov 28, 2023
Merged

[INQUIRY] 문의하기 UI 수정 #109

merged 51 commits into from
Nov 28, 2023

Conversation

junghaesung79
Copy link
Contributor

@junghaesung79 junghaesung79 commented Oct 18, 2023 •
edited
Loading

[#99] request

문의하기 페이지 UI 변경했고
전체 문의 보기 api 연결했습니다.
반응형 css 부분 구현 했습니다.

Please check if the PR fulfills these requirements

  • It's submitted to develop branch, not the main branch
  • The commit message follows our guidelines
  • There are no warning message when you run yarn lint
  • Docs updated for breaking changes

Screenshot

image
image

@junghaesung79 junghaesung79 added the enhancement New feature or request label Oct 18, 2023
@junghaesung79 junghaesung79 self-assigned this Oct 18, 2023
hyejun0228
hyejun0228 requested changes Oct 20, 2023
View reviewed changes
Copy link
Contributor

@hyejun0228 hyejun0228 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다!
우선, 앞선 다른분들의 코드 리뷰들을 정독해주시고 전체적으로 수정 부탁드립니다. 수정 이후 추가적인 코드리뷰 작성하겠습니다!

  • 정말 중요한것 몇가지만 언급하자면, BEM방식의 활용이나 파일 구조 분리, 카멜 케이스 등등 팀에서 이용하고 있는 여러 컨벤션들이 지켜지지 않아 일단 이부분을 집중해서 수정하셔야할것같습니다

src/pages/Inquiry/Inquire/Inquire.module.scss Outdated Show resolved Hide resolved
src/pages/Inquiry/Inquire/Inquire.module.scss Outdated Show resolved Hide resolved
src/pages/Inquiry/Inquire/index.tsx Outdated Show resolved Hide resolved
src/pages/Inquiry/Inquire/index.tsx Outdated Show resolved Hide resolved
kimeodml
kimeodml requested changes Oct 22, 2023
View reviewed changes
Copy link
Contributor

@kimeodml kimeodml left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다. BEM 네이밍에 유의하면서 수정할 필요가 있어보여요!

src/pages/Inquiry/Inquiry/components/DataTable/DataTable.tsx Outdated Show resolved Hide resolved
src/pages/Inquiry/Inquiry/components/DataTable/DataTable.tsx Outdated Show resolved Hide resolved
src/pages/Inquiry/Inquiry/components/DataTable/DataTable.tsx Outdated Show resolved Hide resolved
src/pages/Inquiry/Inquiry/components/DataTable/DataTable.tsx Outdated Show resolved Hide resolved
src/pages/Inquiry/Inquiry/components/SearchBar/SearchInput.tsx Outdated Show resolved Hide resolved
src/pages/Inquiry/Inquiry/components/DataTable/DataTable.tsx Outdated Show resolved Hide resolved
src/pages/Inquiry/Inquiry/components/DataTable/DataTable.tsx Outdated Show resolved Hide resolved
src/pages/Inquiry/Inquiry/index.tsx Outdated Show resolved Hide resolved
src/pages/Inquiry/Inquire/Inquire.module.scss Outdated Show resolved Hide resolved
src/pages/Inquiry/Inquiry/Inquiry.module.scss Outdated Show resolved Hide resolved
chaeseungyun
chaeseungyun requested changes Oct 23, 2023
View reviewed changes
Copy link
Contributor

@chaeseungyun chaeseungyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다!
참고할만한 내용 적어봤습니다

src/api/inquiry/inquiryApiClient.ts Show resolved Hide resolved
src/pages/Inquiry/Inquiry/hooks/useInquiryList.ts Outdated Show resolved Hide resolved
src/pages/Inquiry/Inquiry/hooks/useInquiryList.ts Outdated Show resolved Hide resolved
LUNA-KK
LUNA-KK requested changes Nov 6, 2023
View reviewed changes
Copy link
Contributor

@LUNA-KK LUNA-KK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다!
참고하실 만한 몇 가지 적어두었습니다.

kimeodml
kimeodml reviewed Nov 10, 2023
View reviewed changes
Copy link
Contributor

@kimeodml kimeodml left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PC 버전에서도 inquiry/all로 변경 부탁드립니다!

@junghaesung79
refactor: 필요 없는 함수 제거
66652aa 
- refatchOnMount: always 옵션 추가
@kimeodml
Copy link
Contributor

kimeodml commented Nov 23, 2023 •
edited
Loading

아 근데 이거 브랜치 최신화 한 다음에 yarn lint하시면 오류 뜨나요? 나중에 한 번 develop 머지 전에 확인 부탁드립니다!

@junghaesung79
refactor: query 버전 업
2ec159a 
- 변수명 변경(typePath => queryType)
@junghaesung79 junghaesung79 merged commit 7ff75c3 into develop Nov 28, 2023
1 check passed
@junghaesung79 junghaesung79 deleted the feature/#103 branch February 3, 2024 06:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChoiWonBeen ChoiWonBeen ChoiWonBeen left review comments

@MinGu-Jeong MinGu-Jeong MinGu-Jeong left review comments

@kimeodml kimeodml kimeodml approved these changes

@chaeseungyun chaeseungyun chaeseungyun approved these changes

@LUNA-KK LUNA-KK LUNA-KK approved these changes

@hyejun0228 hyejun0228 hyejun0228 approved these changes

@KimKyungYun KimKyungYun Awaiting requested review from KimKyungYun

@20HyeonsuLee 20HyeonsuLee Awaiting requested review from 20HyeonsuLee

@HAEROOL HAEROOL Awaiting requested review from HAEROOL HAEROOL is a code owner

Assignees

@junghaesung79 junghaesung79

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@junghaesung79 @kimeodml @ChoiWonBeen @MinGu-Jeong @chaeseungyun @LUNA-KK @hyejun0228