Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for 22.04 build #154

Merged
merged 5 commits into from
May 20, 2022
Merged

Conversation

gdevenyi
Copy link
Contributor

Addressing #153 and another bug I got bitten by.

@gdevenyi
Copy link
Contributor Author

@bcdarwin

@gdevenyi
Copy link
Contributor Author

gdevenyi commented May 20, 2022

BIC-MNI/mni_autoreg#28 pending

@gdevenyi
Copy link
Contributor Author

These changes succeed in building on Ubuntu 22.04 under the following config

cmake ../minc-toolkit-v2 -DCMAKE_INSTALL_PREFIX=${install_prefix} \
        -DMT_BUILD_ABC=ON \
        -DMT_BUILD_ANTS=OFF \
        -DMT_BUILD_OPENBLAS=ON \
        -DMT_BUILD_VISUAL_TOOLS=ON \
        -DMT_BUILD_C3D=OFF \
        -DMT_USE_OPENMP=ON \
        -DUSE_SYSTEM_GLUT=ON \
        -DBUILD_TESTING=ON \
        -DMT_PACKAGES_PATH=/opt/quarantine/software/minc-toolkit-v2/packagecache &&

All tests also pass.

@gdevenyi gdevenyi requested a review from vfonov May 20, 2022 16:40
@gdevenyi
Copy link
Contributor Author

After this gets merged, I'd like to tag/release 1.9.18.2

@gdevenyi
Copy link
Contributor Author

Should we default to building openblas so the default config is confirmed buildable?

@bcdarwin
Copy link
Contributor

Should we default to building openblas so the default config is confirmed buildable?

@gdevenyi - building this branch on 22.04 I still hit #153 with external blas, so probably we should?

@gdevenyi
Copy link
Contributor Author

Updated FREEGLUT version to successfully build with the new gcc.

@gdevenyi - building this branch on 22.04 I still hit #153 with external blas, so probably we should?

@bcdarwin ok, will flip the switch.

@vfonov vfonov merged commit 96a7ae7 into BIC-MNI:develop-1.9.18 May 20, 2022
@bcdarwin
Copy link
Contributor

Building for me now on Ubuntus 20.04 and 22.04.

@bcdarwin
Copy link
Contributor

@gdevenyi - tag incoming?

@vfonov
Copy link
Member

vfonov commented May 20, 2022

check if it still builds for CentOS 7

@bcdarwin
Copy link
Contributor

so one general issue is that minc-toolkit-config.sh sets LD_LIBRARY_PATH, and when this contains a BLAS it breaks numpy :)

@bcdarwin
Copy link
Contributor

rebuilding on centos now

@gdevenyi
Copy link
Contributor Author

Tag and release ready

@bcdarwin
Copy link
Contributor

Build succeeded, though I didn't build the visual tools or ANTs/Elastix, but ABC, patch_morphology are fine;
all tests pass.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants