plan classes: add workunit-related filters

[bema-aei]

filters <min_wu_id>, <max_wu_id>, <min_batch>, <max_batch> and <disabled>

• WU information is passed from check_homogeneous_app_version() down to PLAN_CLASS::check()

• wu_is_infeasible_custom() is extended such that additional tasks also follow the plan class restrictions.

[davidpanderson]

Thanks. Please update https://boinc.berkeley.edu/trac/wiki/AppPlanSpec

[davidpanderson]

There may be a problem with this, because the app version selection mechanism caches the selection. It might see an old WU, choose an app version, and then use the same version for a later WU.
Can you please describe the use case in detail?

[brevilo]

Since this PR got merged prematurely please open a new one (and add a xref) to have this discussion in the right place.

Thanks

[bema-aei]

@brevilo I don't know what change I should open a PR with, shall I open an issue?

[bema-aei]

@davidpanderson

There may be a problem with this, because the app version selection mechanism caches the selection. It might see an old WU, choose an app version, and then use the same version for a later WU. Can you please describe the use case in detail?

The modification of PLAN_CLASS::check() selects an application that matches the WU criteria (max/min WU id, max/min batch). The addition to wu_is_infeasible_custom() ensures that subsequent tasks that get selected for this app version also conform to the WU criteria for the app version's plan class. wu_is_infeasible_custom() calls plan_class_specs.wu_is_infeasible(plan_class, wu), which looks up the WU criteria for this plan class and checks whether the WU conforms. WUs that don't conform to the plan class criteria get rejected as 'infeasible'.

[brevilo]

You need to open a new PR to get your changes integrated as this one is "done". Just use your original branch for it.

Now that the discussion already commenced, please keep it here and only reference this PR from the new one to establish a link.