client: fix work fetch messages #5764
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
there are two levels of reason: project-specific and global (i.e. buffer full). Check both reasons when in the no-fetch message. Include CPU in type_name_to_num()
AenBleidd
approved these changes
Aug 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The client shows messages like
8/16/2024 8:13:47 PM | PrimeGrid | Not requesting tasks: don't need (CPU: ; NVIDIA GPU: ; Intel GPU: )
The reasons are missing.
This is because there are two levels of reason for not fetching a resource:
project-level (like it has no app versions that use the resource)
and global (like the buffer is full).
We were only looking at the project-level reason.
Look at both, to produce e.g.
8/16/2024 8:13:47 PM | PrimeGrid | Not requesting tasks: don't need (CPU: buffer full; NVIDIA GPU: buffer full; Intel GPU: buffer full)