feat: Added callbacks onTokenExpiring and onTokenExpired #91
Conversation
| @@ -784,15 +784,6 @@ abstract class OidcUserManagerBase { | |||
| if (user == null) { | |||
| tokenEventsManager.unload(); | |||
| } else { | |||
| if (!discoveryDocument.grantTypesSupportedOrDefault | |||
There was a problem hiding this comment.
This is removed cause handleTokenExpiring should be called even if there is no refreshToken...
akaegi
force-pushed
the
feature/on_token_expiring_callback
branch
from
994a534
to
878f36f
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #91 +/- ##
===========================================
- Coverage 94.87% 16.66% -78.21%
===========================================
Files 3 42 +39
Lines 39 1158 +1119
===========================================
+ Hits 37 193 +156
- Misses 2 965 +963 ☔ View full report in Codecov by Sentry. |
akaegi
changed the title
akaegi
force-pushed
the
feature/on_token_expiring_callback
branch
from
878f36f
to
670bd98
Compare
| @@ -803,6 +794,8 @@ abstract class OidcUserManagerBase { | |||
|
|
|||
| @protected | |||
| Future<void> handleTokenExpiring(OidcToken event) async { | |||
| settings.onTokenExpiring?.call(event); | |||
There was a problem hiding this comment.
should we still refresh using refreshToken if the user provides their own onTokenExpiring callback?
also would it make sense to expose a stream of expiring/expired events instead of callbacks ?
There was a problem hiding this comment.
should we still refresh using refreshToken if the user provides their own onTokenExpiring callback?
Maybe there are scenarios where the user has to do some preparatory work before refresh can happen?
There was a problem hiding this comment.
also would it make sense to expose a stream of expiring/expired events instead of callbacks ?
Whatever you prefer. I could also add events to the existing events stream using new subclasses of OidcEvent (OidcTokenExpiring and OidcTokenExpired)
There was a problem hiding this comment.
@ahmednfwela Any news from your side? Are there any open points that prevent you from merging this PR? This is somehow important to me as I'm currently referencing my fork in our production app 🙈
Background: I use auth flow jwt-bearer where there is no refresh token. Still I want to auto-refresh before the token expires. The new callback
onTokenExpiringcan be used to achieve this.