Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add multi executable support #11

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

arihant2math
Copy link

Resolves #8. Its a port of tauri-apps/winres#8.

@BenjaminRi
Copy link
Owner

Thank you for the PR. I reviewed it and, unfortunately, it does not seem to work with the GNU toolchain as mentioned in tauri-apps/winres#8 (comment) .

  = note: x86_64-w64-mingw32-gcc: error: example-b.o: No such file or directory
          x86_64-w64-mingw32-gcc: error: unrecognized command-line option '--whole-archive'; did you mean '--whole-file'?

I really like the idea of supporting multiple binaries, but I cannot merge this in good conscience as it will lead to toolchain-dependent breakage.

Additionally, a minor blemish: A variable is overwritten without being used, which the compiler warns about:

warning: unused variable: `rc`
   --> lib.rs:694:13
    |
694 |         let rc = output.join("resource.rc");
    |             ^^ help: if this is intentional, prefix it with an underscore: `_rc`
    |
    = note: `#[warn(unused_variables)]` on by default

warning: `winresource` (lib) generated 1 warning (run `cargo fix --lib -p winresource` to apply 1 suggestion)
    Finished dev [unoptimized + debuginfo] target(s) in 3.37s

The line could simply be omitted:

let rc = output.join("resource.rc");

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for a multi executable build
2 participants