Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more tests for layers in 3 d/4 d #315

Merged
merged 12 commits into from
Apr 24, 2024
Merged

Conversation

zoccoler
Copy link
Collaborator

This adds extra tests and should fix #302

@jo-mueller , could you take a look?

Copy link

codecov bot commented Apr 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.57%. Comparing base (69714c2) to head (8c89d55).
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #315      +/-   ##
==========================================
+ Coverage   77.20%   79.57%   +2.36%     
==========================================
  Files          16       16              
  Lines        1904     2071     +167     
==========================================
+ Hits         1470     1648     +178     
+ Misses        434      423      -11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zoccoler
Copy link
Collaborator Author

mac tests disabled for the moment (related issue: actions/setup-python#808)

Copy link
Collaborator

@jo-mueller jo-mueller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some minor suggestions to make sure that we are always handling 4D data

zoccoler and others added 4 commits April 24, 2024 08:39
Co-authored-by: Johannes Soltwedel <38459088+jo-mueller@users.noreply.github.com>
@zoccoler zoccoler merged commit 30a3c0c into main Apr 24, 2024
4 of 5 checks passed
@jo-mueller jo-mueller deleted the add-more-tests-for-layers-in-3D/4D branch May 13, 2024 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Test current version before releasing
2 participants