Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix reconcilliation errors #56

Merged
merged 9 commits into from
Feb 7, 2023
Merged

Fix reconcilliation errors #56

merged 9 commits into from
Feb 7, 2023

Conversation

BojanZelic
Copy link
Owner

No description provided.

@codecov
Copy link

codecov bot commented Feb 7, 2023

Codecov Report

Base: 59.63% // Head: 61.88% // Increases project coverage by +2.25% 🎉

Coverage data is based on head (164dd87) compared to base (48e5169).
Patch coverage: 72.65% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #56      +/-   ##
==========================================
+ Coverage   59.63%   61.88%   +2.25%     
==========================================
  Files          17       17              
  Lines        1209     1186      -23     
==========================================
+ Hits          721      734      +13     
+ Misses        398      371      -27     
+ Partials       90       81       -9     
Impacted Files Coverage Δ
internal/ctrlhelper/controllerHelper.go 55.55% <54.54%> (+5.55%) ⬆️
controllers/cloudflareservicetoken_controller.go 69.18% <71.18%> (+4.97%) ⬆️
...trollers/cloudflareaccessapplication_controller.go 65.49% <71.42%> (+4.17%) ⬆️
controllers/cloudflareaccessgroup_controller.go 59.32% <83.33%> (+6.82%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@BojanZelic BojanZelic merged commit 9626ca8 into main Feb 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant