Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update markdown editor display to update DOM instead of replace #3454

Closed
ssddanbrown opened this issue May 23, 2022 · 0 comments
Closed

Update markdown editor display to update DOM instead of replace #3454

ssddanbrown opened this issue May 23, 2022 · 0 comments
Labels
💻 Front-End > Markdown Editor
Milestone
v22.06

Comments

@ssddanbrown
Copy link
Member

Probably through some kind of vdom diffing technique.
Avoids reloading of embedded content such as that in #3452, and should provide a smoother editing experience.
@ssddanbrown ssddanbrown added this to the Next Feature Release milestone May 23, 2022
@ssddanbrown ssddanbrown changed the title Update markdown display to update DOM instead of replace Update markdown editor display to update DOM instead of replace May 23, 2022
yangmx5 pushed a commit to yangmx5/BookStack that referenced this issue Jun 19, 2022
@ssddanbrown
Updated markdown preview to update on diff-basis
6f4dc94 
Uses vdom system to diff and update the current markdown preview view
instead of requiring a full HTML replace change.
This should provide better performance, expecially where dynamically
loaded content such as iframes were in use.

Closes BookStackApp#3454
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
💻 Front-End > Markdown Editor
Milestone
v22.06
Development

No branches or pull requests
1 participant
@ssddanbrown