Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

598/maskmasker quick plot #599

Merged
merged 14 commits into from
Nov 23, 2022
Merged

598/maskmasker quick plot #599

merged 14 commits into from
Nov 23, 2022

Conversation

jpolton
Copy link
Collaborator

@jpolton jpolton commented Nov 16, 2022

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (./build.sh) was run locally and no errors reported. NB not sure about this requirement: GitActions test this
  • Lint (pylint .) has passed locally and any fixes were made for failures. NB not sure about this requirement: GitActions test this with black

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

MaskMaker() is missing a means to visualise regional masks

Issue URL: #598

What is the new behavior?

  • MaskMaker.quick_plot() is a means to visualise regional masks
  • Updated definitions of English Channel to not overlap with southern North Sea
  • Added mask masker tutorial to notebook

Checklist

  • Code compiles correctly
  • Created tests which fail without the change (if possible)
  • All tests passing (pip install . && pytest unit_testing/unit_test.py -s)
  • Extended the README / documentation, if necessary
  • Added myself / the copyright holder to the AUTHORS file

Does this introduce a breaking change?

  • Yes
  • No

Other information

@jpolton jpolton self-assigned this Nov 16, 2022
@jpolton jpolton marked this pull request as ready for review November 16, 2022 13:28
@jpolton
Copy link
Collaborator Author

jpolton commented Nov 21, 2022

@anwiseNOCL could you do a review of this? Should be straight forward without surprises
Highlights:

  • MaskMaker.quick_plot() is a means to visualise regional masks
  • Updated definitions of English Channel to not overlap with southern North Sea
  • Added mask masker tutorial to notebook

Copy link
Collaborator

@anwiseNOCL anwiseNOCL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues here

@jpolton jpolton merged commit fbe4b92 into develop Nov 23, 2022
@jpolton jpolton deleted the 598/maskmasker_quick_plot branch November 28, 2022 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants