-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bug fixes in process_en4() #609
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r EN versions. Tidy profile.py
…ature/606_profile_bug
…ename north_sea region to north_north_sea
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
Please check if your PR fulfills the following requirements:
COAsT-site
repo, in a separate PR. See contributing to documentation for details../build.sh
) was run locally and no errors reported. NB not sure about this requirement: GitActions test thispylint .
) has passed locally and any fixes were made for failures. NB not sure about this requirement: GitActions test this withblack
Pull request type
Please check the type of change your PR introduces:
What is the current behavior?
Issue URL: #608
What is the new behavior?
nan masking of bad salinity point was misapplied using temperature mask locations:
should read
Also, though data points with bad values were masked with NaN, and profiles with both bad salinity and temperature were removed, profiles with bad temperature or salinity were not masked.
On inspection, other minor issues:
Method name change
calculate_all_en4_qc_flags()
only representscalculate_en4_qc_flags_levels()
, and not profiles.Hence a name change/refactor
Duplicated methods in profile.py
calculate_all_en4_qc_flags()
appears twiceprocess_en4()
appears twiceIn
calculate_en4_qc_flags_levels()
:Different versions of EN dataset have a slightly different justitifcation of why some points are removed. This is inconsequential to the implementation of which points/profiles get masked but the code is updated to reflect this knowledge - perhaps making it more readable.
double mapping:
Within profile.py (insitu)
temperature
was being mapped to bothtemperature
andpotential temperature
. The variable should be preserved in this code and mappings happen exclusively in the json filesAdd profile.mask_stats()
Checklist
pip install . && pytest unit_testing/unit_test.py -s
)Does this introduce a breaking change?
Other information