Skip to content

Commit

Permalink
Merge pull request #1220 from Bynder/debt/GC-1083_Fix_console_log_spa…
Browse files Browse the repository at this point in the history
…m_in_item_editor

GC-1083 - Fix console log spam in item editor
  • Loading branch information
timbryandev committed Jun 21, 2023
2 parents db99f81 + e860e35 commit 212194c
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 5 deletions.
7 changes: 5 additions & 2 deletions lib/Dropdown/DropdownAction.js
Original file line number Diff line number Diff line change
Expand Up @@ -17,12 +17,15 @@ const DropdownAction = ({
overflow,
disabled,
value,
showContent: showContentProp,
toggleShowContent: toggleShowContentProp,
...props
}) => {
const {
toggleShowContent = props.toggleShowContent,
showContent = props.showContent
toggleShowContent = toggleShowContentProp,
showContent = showContentProp
} = useContext(DropdownContext) || {};

const classNames = cx(`dropdown__action ${className}`, {
'dropdown__action--danger': danger,
'dropdown__action--noBg': noBackground,
Expand Down
6 changes: 3 additions & 3 deletions lib/src/modules/Button/ButtonBase.js
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
/* eslint-disable react/button-has-type */
import React from 'react';
import cx from 'classnames';
import { string, arrayOf, bool, oneOfType } from 'prop-types';
import { arrayOf, bool, oneOfType, string } from 'prop-types';
import Icon from 'lib/Icon';
import { propTypes, defaultProps, sizes } from './common';
import { defaultProps, propTypes, sizes } from './common';

function ButtonBase({
children,
Expand All @@ -16,6 +16,7 @@ function ButtonBase({
connectedRight,
disabled,
buttonRef,
defaultFillColor,
...rest
}) {
const classes = cx('button-base', className, {
Expand All @@ -32,7 +33,6 @@ function ButtonBase({
}

const loaderTypesWithDisabled = disabled ? ['dark'] : loaderTypes;

return (
<button className={classes} disabled={disabled} ref={buttonRef} {...rest}>
{loading && !loaderRight && (
Expand Down

0 comments on commit 212194c

Please sign in to comment.