GC-3696 update blue primary and add new screen sizes #1327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
micmcgrorty
requested review from
lewishankinson,
timbryandev and
AmeeMorris
timbryandev
reviewed
Nov 29, 2023
package.json
Outdated
| @@ -57,7 +57,7 @@ | |||
| "dist" | |||
| ], | |||
| "scripts": { | |||
| "build": "rm -rf dist && babel --extensions '.ts,.tsx' lib/ --out-dir dist/lib && babel tailwind.config.js --out-dir dist && npm run compile:css && npm run legacy:copy-styles && npm run generate-types", | |||
There was a problem hiding this comment.
Is there a reason we're removing the type generation?
I could be wrong, but I think we import those types in SSR so we can have type safety where we're using the mono components?
There was a problem hiding this comment.
Oops, didn't mean to commit that.
There was a problem hiding this comment.
Ah no worries :) all good!
timbryandev
approved these changes
Nov 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💬 Description
Updated the blue primary colour to match mono, and update the screen sizes object to match mono.