Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Common - Improve remove magazine functions #1650

Merged
merged 3 commits into from
Mar 31, 2024

Conversation

johnb432
Copy link
Contributor

When merged this pull request will:

  • FUNC(removeMagazine):
    • No longer config case sensitive.
    • Round the ammo count before treating request.
    • Because the description states that it can be run on units or vehicles, I have added vehicle support, as previously it did not support vehicles at all.
    • Code improvement brought over from ACE ace_common_fnc_removeMagazineSpecific
  • FUNC(removeMagazineCargo)
    • No longer config case sensitive.
    • Round the ammo count before treating request.
    • Only removes the necessary magazines.

@PabstMirror PabstMirror added this to the 3.16.2 milestone Mar 26, 2024
@jonpas
Copy link
Member

jonpas commented Mar 30, 2024

All tests still pass?

@PabstMirror
Copy link
Contributor

tests pass

@johnb432
Copy link
Contributor Author

I should write new tests, as FUNC(removeMagazine) properly supports vehicles. Looks like no tests exist for FUNC(removeMagazineCargo), I can add those.

@jonpas
Copy link
Member

jonpas commented Mar 30, 2024

Please do. :)

@johnb432
Copy link
Contributor Author

Please do. :)

Done.

@jonpas
Copy link
Member

jonpas commented Mar 31, 2024

@PabstMirror Double check for me and merge?

@PabstMirror PabstMirror merged commit 332bfbd into CBATeam:master Mar 31, 2024
4 checks passed
@johnb432 johnb432 deleted the remove-magazines branch March 31, 2024 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants