Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix docker containers & bind mounts #69

Merged
merged 14 commits into from
Sep 18, 2023
Merged

Fix docker containers & bind mounts #69

merged 14 commits into from
Sep 18, 2023

Conversation

kelly-sovacool
Copy link
Member

@kelly-sovacool kelly-sovacool commented Sep 15, 2023

Changes

  • Adds docker containers to process definitions, using parameters for shared containers.
  • Uses --mount type=bind instead of --bind (singularity) for compatibility with docker.
  • Instead of mounting the chromosomes dir for gem, passes it as an input -- similar to the reference files for alignment processes.
  • Fixes output files from the gem stub.

Issues

PR Checklist

(Strikethrough any points that are not applicable.)

  • This comment contains a description of changes with justifications, with any relevant issues linked.
  • [ ] Write unit tests for any new features, bug fixes, or other code changes. testing framework not yet implemented
  • [ ] Update docs if there are any API changes.
  • [ ] If a new nextflow process is implemented:
    • [ ] docker container is set in conf/modules.config.
    • [ ] stub is defined.
  • Update CHANGELOG.md with a one-line description of these changes and reference the PR number. Guidelines: https://keepachangelog.com/en/1.1.0/

@kelly-sovacool
Copy link
Member Author

Can't get past this error on GitHub Actions with Docker. It works fine with singularity on biowulf.

docker: Error response from daemon: invalid mount config for type "bind": bind source path does not exist:

@kopardev kopardev added this to the 2023w38_0922 milestone Sep 18, 2023
@kelly-sovacool
Copy link
Member Author

kelly-sovacool commented Sep 18, 2023

Actions is still not running process stubs past fastq_screen. Seems like something is up with the reference files paths. Going to merge this as-is since it does fix the issues linked above, and will circle back to the stubs problem later.
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants