Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Overflow issue on homescreen. #15

Closed
Aadeesh11 opened this issue Dec 26, 2021 · 3 comments · Fixed by #19
Closed

Overflow issue on homescreen. #15

Aadeesh11 opened this issue Dec 26, 2021 · 3 comments · Fixed by #19
Assignees
@Aadeesh11

Comments

@Aadeesh11
Copy link
Contributor

Getting a overflow issue on Homescreen due to the 2 buttons.

overflow

I would like to work on this, please assign it to me.
Aadeesh11 added a commit to Aadeesh11/beacon that referenced this issue Dec 26, 2021
@Aadeesh11
fixes CCExtractor#15
b546475
@nb9960
Copy link
Collaborator

nb9960 commented Dec 26, 2021

Assigning it to you @Aadeesh11. I would suggest using sizer for responsiveness.

@Aadeesh11
Copy link
Contributor Author

Aadeesh11 commented Dec 26, 2021 •
edited
Loading

I have already fixed the issue, but will have a look at sizer too.
Should i create a PR for the fix i have implemented?

@nb9960
Copy link
Collaborator

nb9960 commented Dec 26, 2021

Yes, I just checked your commit, you have used constant values. It would be better to change it and make it responsive throughout using sizer as a good practice.

@Aadeesh11 Aadeesh11 mentioned this issue Dec 26, 2021
Merged
nb9960 pushed a commit that referenced this issue Dec 28, 2021
@Aadeesh11
fix: Overflow issue on homscreen (#19)
d9455a0 
* fixes #15
* fix: used sizer to fix overflow issue on homescreen.
* rfrac: used pub dependency instead of git.
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Aadeesh11 Aadeesh11

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Sizer]: Overflow issue fix on homscreen Aadeesh11/beacon
2 participants
@nb9960 @Aadeesh11