Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

This line is misleading as a text field #158

Closed
vik4114 opened this issue Mar 20, 2022 · 10 comments · May be fixed by #170
Closed

This line is misleading as a text field #158

vik4114 opened this issue Mar 20, 2022 · 10 comments · May be fixed by #170
Assignees
Labels

Comments

@vik4114
Copy link

vik4114 commented Mar 20, 2022

Is your feature request related to a problem? Please describe.
This line is misleading as a text field and if it is acting as a partition still it is not symmetric

Screenshot
Screenshot_1647773488_1

Describe the solution you'd like
I think we should remove it

Describe alternatives you've considered
-Else we can make it symmetric
-Or Bring it just below the text field

Additional context
Sol 1
Screenshot_1647773488_2

Sol2
Screenshot_1647773488_3

Are you working on this? (Yes/No)
Yes

@vik4114
Copy link
Author

vik4114 commented Mar 21, 2022

@nb9960 What do you think?

@ItsAdityaKSingh
Copy link
Collaborator

@vik4114 afaik that line is a mere partition between the two fields and is only for UI purposes. It has nothing to do with the textfields or symmetry. It's there to only get a general idea to users for where the divide lies between them.

@vik4114
Copy link
Author

vik4114 commented Mar 21, 2022

@ItsAdityaKSingh But without the line it looks good

@nb9960
Copy link
Collaborator

nb9960 commented Mar 31, 2022

I guess the same follows for the other text fields too and because UI needs to be consistent, you'll have to make the changes throughout.
Additionally, that line acted as a partition removing it doesn't look good, the latter one is still better (i.e, to add the line below the text field)

@srockstech
Copy link

@vik4114 Are you still working on this issue?

@vik4114
Copy link
Author

vik4114 commented Apr 10, 2022

@srockstech Yes, I was stuck with other work, I will raise pr soon.

@K1RA-16
Copy link

K1RA-16 commented Apr 11, 2022

@srockstech Yes, I was stuck with other work, I will raise pr soon.

Hi vik can i work on this if possible ??

@ItsAdityaKSingh
Copy link
Collaborator

Hey, @vik4114, are you working on resolving this?

@RohanSengupta326
Copy link

I think no one solved this issue, so I created a PR(#170). So please check. @ItsAdityaKSingh

@pnkr01
Copy link

pnkr01 commented Nov 13, 2022

is this issue resolved ??
@ItsAdityaKSingh

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants