Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refresh on pull implemented for group screen tabs + UI changes to the auth screen #173

Closed
wants to merge 0 commits into from

Conversation

Rushour0
Copy link

@Rushour0 Rushour0 commented Oct 28, 2022

Fixes #
Added a custom pull to refresh mentioned in the issue #91
I have also made UI changes to the auth screen mentioned in the issue #158

Describe the changes you have made in this PR -
Issue 91
Made a new TabControllerStorage since we cannot late initialise the tabcontroller, and thus cannot declare it out of the build method. Storing the tab index using this singleton implementation.
Added a new package custom_refresh_indicator to implement the pull to refresh feature with a custom icon

Issue 158
Made changes to the UI to make it better looking and user friendly.

Screenshots of the changes (If any) -
Issue 91

pull_to_refresh_feature.mp4

Issue 158
login
signup

Note: Please check Allow edits from maintainers. if you would like us to assist in the PR.

@Rushour0 Rushour0 changed the title refresh on pull implemented for group screen tabs refresh on pull implemented for group screen tabs + UI changes to the auth screen Oct 29, 2022
@Rushour0
Copy link
Author

Rushour0 commented Nov 6, 2022

please check the new commit, fixed the getter setter error

@ItsAdityaKSingh
Copy link
Collaborator

ItsAdityaKSingh commented Nov 6, 2022

Hey @Rushour0! Could you make a new branch and rebranch these changes? It's a good practice to create branches for changes you are proposing rather than making a pull request directly from the main branch :)
Also, the buttons' border radius that you have changed makes it a more box-like structure. Let's stick to a more curved button style, so if possible, could you change it too?

@Rushour0
Copy link
Author

Rushour0 commented Nov 9, 2022

@ItsAdityaKSingh Alright, I will make the due Button UI changes and push it to a new branch itself
Should I make a PR to development branch or make my own branch and push the whole repo with the branch in it?

Thanks for the help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants