Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Appearance of Sign In button #22

Closed
ItsAdityaKSingh opened this issue Dec 26, 2021 · 2 comments · Fixed by #45
Closed

Appearance of Sign In button #22

ItsAdityaKSingh opened this issue Dec 26, 2021 · 2 comments · Fixed by #45
Assignees
@ItsAdityaKSingh
Labels
good first issue Good for newcomers UI improvement

Comments

@ItsAdityaKSingh
Copy link
Collaborator

The SIGIN button for new users has a weird appearance.

  • Instead of SIGNIN we can show it as SIGN IN
  • Also we could change the width of the button to make it look more pleasant.
@ItsAdityaKSingh
Copy link
Collaborator Author

If this issue seems genuine, could you assign it to me @nb9960 ?

@nb9960
Copy link
Collaborator

nb9960 commented Dec 27, 2021 •
edited
Loading

  • Also, we could change the button's width to make it look more pleasant.

UI needs to be consistent. Changing the sign-in button's width in one place would mean changing it everywhere possible.

Assigning it to you!

@nb9960 nb9960 added the good first issue Good for newcomers label Dec 27, 2021
@nb9960 nb9960 mentioned this issue Dec 27, 2021
Closed
This was referenced Dec 27, 2021
Closed
Merged
@nb9960 nb9960 linked a pull request Dec 29, 2021 that will close this issue
Updated UI, fixed bugs and refactored code #45
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ItsAdityaKSingh ItsAdityaKSingh

Labels
good first issue Good for newcomers UI improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Updated UI, fixed bugs and refactored code ItsAdityaKSingh/beacon
2 participants
@nb9960 @ItsAdityaKSingh