Updated UI, fixed bugs and refactored code #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ItsAdityaKSingh
force-pushed
the
ui_and_bugs
branch
from
ac935ca
to
bea3c91
Compare
Closed
|
Fixed the issue #44 here itself |
This was
linked to
issues
Dec 29, 2021
Closed
nb9960
requested changes
Dec 29, 2021
nb9960
reviewed
Jan 9, 2022
There was a problem hiding this comment.
Hey @ItsAdityaKSingh, This PR still doesn't reflect the desired changes. In fact, UI had no issues earlier, but now it has (adding the screenshot below for reference). Maybe run gh pr checkout 45 or make sure you've pulled the changes locally and then try to test your changes.
nb9960
approved these changes
Jan 12, 2022
|
Thanks for the PR @ItsAdityaKSingh , Merged! 🎉 |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes issues:
Along with the UI improvements and minor bug fixes, I have minutely refactored the code for proper readability and understanding, added commas(,) at a few places, fixed sizing issues for all the containers and buttons, and also tried to improve the overall interface. Any suggestions for improvements are most welcome!