Test: Model test (Beacon and User model). #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aadeesh11
force-pushed
the
tests
branch
2 times, most recently
from
b9e3a35
to
fe336f1
Compare
Aadeesh11
changed the title
Diff Lat/Lon values. User model test added. Added update method test.
nb9960
previously approved these changes
Feb 12, 2022
nb9960
reviewed
Feb 12, 2022
test/model_tests/user_test.dart
Outdated
Comment on lines
9
to
10
| "name": "asdasd", | ||
| "email": "asdf@g.com", |
There was a problem hiding this comment.
Instead of adding random alphabets, I think it would be better to be more generic, like change it to "test_name"
And also since you've written the model tests it would be better to add validation check too. For ex: _id can't be null (similarly for other fields in user and beacon model)
There was a problem hiding this comment.
Sure, will do the needful!
This was referenced Feb 12, 2022
8 tasks
nb9960
approved these changes
Feb 16, 2022
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#46
Describe the changes you have made in this PR - Tested beacon and user model's methods.