Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #110 and #163 solved (AlterDialog UI fixes and made loading screen) #161

Merged
merged 2 commits into from
Jun 24, 2022

Conversation

codewithkushagra
Copy link
Contributor

@codewithkushagra codewithkushagra commented Apr 16, 2022

#110 and #163

I have made the Alertdialog box edges round, for logout pop up

WhatsApp Image 2022-04-16 at 7 47 02 PM
WhatsApp Image 2022-04-16 at 7 47 31 PM

Consistent login screen added everywhere with image from assets and the loading animation

WhatsApp.Video.2022-04-17.at.9.19.53.PM.mp4

Note: Please check Allow edits from maintainers. if you would like us to assist in the PR.

@codewithkushagra codewithkushagra changed the title Issue #111 solved (AlterDialog UI fixes) Issue #110 solved (AlterDialog UI fixes) Apr 16, 2022
@codewithkushagra codewithkushagra changed the title Issue #110 solved (AlterDialog UI fixes) Issue #110 and #163 solved (AlterDialog UI fixes and made loading screen) Apr 16, 2022
@codewithkushagra
Copy link
Contributor Author

I have added a loading screen which is consistent and also corrected the logout pop up round property, please review my PR

@nb9960
Copy link
Collaborator

nb9960 commented Apr 18, 2022

You've pushed all the previous commits, which obviously isn't a good practice. Please only push the changes you've made to the existing codebase.

@codewithkushagra codewithkushagra changed the base branch from development to main April 18, 2022 06:34
@codewithkushagra
Copy link
Contributor Author

You've pushed all the previous commits, which obviously isn't a good practice. Please only push the changes you've made to the existing codebase.

Please review the PR once, is this right

@ItsAdityaKSingh
Copy link
Collaborator

LGTM. Could you review it @nb9960?

@nb9960 nb9960 merged commit f9ef249 into CCExtractor:main Jun 24, 2022
This was referenced Jun 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants