Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Updated/Replacing dependencies used. #185

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

CyberWake
Copy link

Fixes #184

Describe the changes you have made in this PR -

  1. The first thing that was breaking on android side was the compileSdkVersion which was set to 30 previously which needed to be 30 to fix the following error Screenshot 1.

  2. in android android/build.gradle needed update in ext.kotlin_version to resolve the following error shown in Screenshot 2.

  3. The second fix was to update package

    • graphql_flutter was needed updated to latest version. Which required connectivity_plus to be updated to its latest version which in turn required rxdart to be updated to its latest version. This was done to resolve the error shown in Screenshot 3.
    • flutter_duration_picker is no longer maintained by the owner hence the newer updated fork published as a package on pub dev was used. This was done to resolve error shown in Screenshot 4.
  4. Added .env to gitignore to ensure the environment variables don't get pushed to GitHub.

Screenshots of the changes (If any) -

Screenshot 1
Screenshot 2023-02-22 at 1 59 13 AM
Screenshot 2
Screenshot 2023-02-22 at 2 07 21 AM
Screenshot 3
Screenshot 2023-02-22 at 1 19 51 AM
Screenshot 4
Screenshot 2023-02-22 at 2 21 52 AM

@ItsAdityaKSingh
Copy link
Collaborator

Hey @CyberWake, could you rebase your changes to the main branch here, as all the changes and commits are currently being added there?

@CyberWake
Copy link
Author

@ItsAdityaKSingh could you please review this PR.

@ItsAdityaKSingh
Copy link
Collaborator

@ItsAdityaKSingh could you please review this PR.

You need to rebase this PR to the main branch of the beacon; currently, it is aimed at the development branch.

@CyberWake CyberWake changed the base branch from development to main March 18, 2023 18:14
@@ -44,3 +44,6 @@ app.*.map.json
/android/app/debug
/android/app/profile
/android/app/release

# Excluding environment file
.env
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

better to have *.env so that any environment file is automatically ignored

# platform :ios, '11.0'

# CocoaPods analytics sends network stats synchronously affecting flutter build latency.
ENV['COCOAPODS_DISABLE_STATS'] = 'true'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we already have a podfile. no need for new as this one seems the same

child: FlatButton(
splashColor: Colors.white,
highlightColor: Colors.white,
child: TextButton(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i assume this change is because flatbutton is deprecated. But this change doesn't match with the PR. If you're doing this upgrade, pls do it for entire project

@@ -12,7 +12,7 @@ dependencies:

cupertino_icons: ^1.0.2
fluttertoast: ^8.0.3
connectivity_plus: ^1.0.2
connectivity_plus: ^3.0.3
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what's the need of this update? 1.0.2 works fine?

import 'package:fluttertoast/fluttertoast.dart';
import 'package:geocoder/geocoder.dart';
import 'package:google_maps_flutter/google_maps_flutter.dart';
import 'package:graphql_flutter/graphql_flutter.dart';
import 'package:intl/intl.dart';
import 'package:location/location.dart';
import 'package:modal_progress_hud/modal_progress_hud.dart';
import 'package:flutter_polyline_points/flutter_polyline_points.dart';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are all of these unused imports?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants