-
Notifications
You must be signed in to change notification settings - Fork 148
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed Create Group and join a group button differences #200
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why were the changes required in pubspec, gradle, and user_info.g.dart
files? The only change required should be in the home_screen.dart
file.
Yeah ! Actually the changes have to be made in home_screen.dart . But since when I forked the code some of the versions have to be updated |
I think it will be better to make changes only in |
@@ -8,7 +8,7 @@ | |||
.buildlog/ | |||
.history | |||
.svn/ | |||
*.env | |||
.env |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this change seems unnecessary. if you remove *, you will only remove files with name .env
. Having *.env
makes sure that any env file is ignored.
please revert is back
@@ -1,12 +1,12 @@ | |||
buildscript { | |||
ext.kotlin_version = '1.6.10' | |||
ext.kotlin_version = '1.8.0' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the code runs fine without this change. Why needed? can you check
@@ -20,11 +20,10 @@ class UserAdapter extends TypeAdapter<User> { | |||
authToken: fields[1] as String, | |||
email: fields[3] as String, | |||
name: fields[2] as String, | |||
location: fields[6] as Location, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removing a field about user model seems like a bad idea. This field is essential to user info model
@@ -178,7 +178,7 @@ class _MainScreenState extends State<MainScreen> with TickerProviderStateMixin { | |||
width: 45.w, | |||
child: HikeButton( | |||
buttonWidth: homebwidth, | |||
buttonHeight: homebheight - 2, | |||
buttonHeight: homebheight - 13.5, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this change won't fix the issue. The issue is wrt text length and button width and height. It works fine on some devices with more width and in some cases the text goes into next line.
pls think of some way to make text more adaptive which can work on all devices
Fixes #
Changed the sizes of the 'Create a group' and 'Join a group' buttons to be equal in size for consistency and improved aesthetics.
Screenshots of the changes-
![Screenshot (221)](https://user-images.githubusercontent.com/77429826/226483965-3c420344-0031-4dc1-8e3f-8bda4541221e.png)
![Screenshot (222)](https://user-images.githubusercontent.com/77429826/226484668-d6697f86-9d82-435a-a2a9-c0b5d63a30bc.png)
Before
After