Fixed Create Group and join a group button differences #200
Conversation
firoz3130
changed the title
firoz3130
changed the title
Yeah ! Actually the changes have to be made in home_screen.dart . But since when I forked the code some of the versions have to be updated |
|
I think it will be better to make changes only in |
| @@ -8,7 +8,7 @@ | |||
| .buildlog/ | |||
| .history | |||
| .svn/ | |||
| *.env | |||
| .env | |||
There was a problem hiding this comment.
this change seems unnecessary. if you remove *, you will only remove files with name .env. Having *.env makes sure that any env file is ignored.
please revert is back
| @@ -1,12 +1,12 @@ | |||
| buildscript { | |||
| ext.kotlin_version = '1.6.10' | |||
| ext.kotlin_version = '1.8.0' | |||
There was a problem hiding this comment.
the code runs fine without this change. Why needed? can you check
| @@ -20,11 +20,10 @@ class UserAdapter extends TypeAdapter<User> { | |||
| authToken: fields[1] as String, | |||
| email: fields[3] as String, | |||
| name: fields[2] as String, | |||
| location: fields[6] as Location, | |||
There was a problem hiding this comment.
removing a field about user model seems like a bad idea. This field is essential to user info model
| @@ -178,7 +178,7 @@ class _MainScreenState extends State<MainScreen> with TickerProviderStateMixin { | |||
| width: 45.w, | |||
| child: HikeButton( | |||
| buttonWidth: homebwidth, | |||
| buttonHeight: homebheight - 2, | |||
| buttonHeight: homebheight - 13.5, | |||
There was a problem hiding this comment.
this change won't fix the issue. The issue is wrt text length and button width and height. It works fine on some devices with more width and in some cases the text goes into next line.
pls think of some way to make text more adaptive which can work on all devices
Fixes #
Changed the sizes of the 'Create a group' and 'Join a group' buttons to be equal in size for consistency and improved aesthetics.
Screenshots of the changes-
Before
After