-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expired beacons fix. #33
Conversation
Show expired beacons at the very last in your beacons section + No streams should be running (including the one that tracks location) Tried to implement this.
Should the last(5th) be part of backend logic or frontend? Because if it is a part of frontend logic, then while joining we would need an extra network call to get beacon data(since we only know short-code at the time of joining). @nb9960 please let me know on how to proceed from here. |
Anything related to security / privacy / etc must be handled in the backend - you just can't trust the frontend :-) So the backend should prevent joining an expired beacon, return some error, and then the frontend can capture that error and display it. |
Ok understood, would create a new issue regarding this in the beacon-backend repository. |
…ining any beacon.
CI would pass once #42 gets merged. |
Suggested changes. Co-authored-by: Nishtha Bodani <nbodani8@gmail.com>
Also, can you change the beacon exit dialog when the beacon has expired? Currently, the message is: 'There are ${X - 1} followers and you are carrying the beacon. Do you want to terminate the hike?'. Change it to 'Are you sure you want to exit? or something similar' if beacon has expired. |
Would change that too. |
Thanks for the PR, merged! 🎉 |
Fixes: #20
Expected Behaviour: