Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expired beacons fix. #33

Merged
merged 24 commits into from
Dec 30, 2021
Merged

Conversation

Aadeesh11
Copy link
Contributor

@Aadeesh11 Aadeesh11 commented Dec 27, 2021

Fixes: #20
Expected Behaviour:

  • Show expired beacons at the very last in your beacons section.
  • Cancel subscriptions (if subscriptions have already been setup) and not setup them up at all (if user opens an expired beacon).
  • Show snackBar if user tries to join expired beacon.
  • Hide the share button if beacon has expired.
  • Stop user from joining expired beacon (Would be handled by backend)

@Aadeesh11
Copy link
Contributor Author

Aadeesh11 commented Dec 27, 2021

Should the last(5th) be part of backend logic or frontend? Because if it is a part of frontend logic, then while joining we would need an extra network call to get beacon data(since we only know short-code at the time of joining).

@nb9960 please let me know on how to proceed from here.
Also please mention if any task has been left-out 😅.

@Aadeesh11 Aadeesh11 mentioned this pull request Dec 27, 2021
@cfsmp3
Copy link
Collaborator

cfsmp3 commented Dec 28, 2021

Should the last(5th) be part of backend logic or frontend?

Anything related to security / privacy / etc must be handled in the backend - you just can't trust the frontend :-)

So the backend should prevent joining an expired beacon, return some error, and then the frontend can capture that error and display it.

@Aadeesh11
Copy link
Contributor Author

Should the last(5th) be part of backend logic or frontend?

Anything related to security / privacy / etc must be handled in the backend - you just can't trust the frontend :-)

So the backend should prevent joining an expired beacon, return some error, and then the frontend can capture that error and display it.

Ok understood, would create a new issue regarding this in the beacon-backend repository.

@Aadeesh11
Copy link
Contributor Author

CI would pass once #42 gets merged.

@Aadeesh11 Aadeesh11 marked this pull request as ready for review December 28, 2021 13:02
lib/views/hike_screen.dart Outdated Show resolved Hide resolved
Suggested changes.

Co-authored-by: Nishtha Bodani <nbodani8@gmail.com>
@nb9960
Copy link
Collaborator

nb9960 commented Dec 29, 2021

Also, can you change the beacon exit dialog when the beacon has expired? Currently, the message is: 'There are ${X - 1} followers and you are carrying the beacon. Do you want to terminate the hike?'. Change it to 'Are you sure you want to exit? or something similar' if beacon has expired.

@Aadeesh11
Copy link
Contributor Author

Also, can you change the beacon exit dialog when the beacon has expired? Currently, the message is: 'There are ${X - 1} followers and you are carrying the beacon. Do you want to terminate the hike?'. Change it to 'Are you sure you want to exit? or something similar' if beacon has expired.

Would change that too.

@nb9960 nb9960 merged commit 1421f5c into CCExtractor:main Dec 30, 2021
@nb9960
Copy link
Collaborator

nb9960 commented Dec 30, 2021

Thanks for the PR, merged! 🎉

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Beacons]: Users can see beacons even after they have expired.
3 participants