Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: dispay error if duration is 0:00:00 #43

Merged
merged 26 commits into from
Dec 29, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
255cd62
added github ci actions
devansh12b2 Dec 27, 2021
ef019ff
Merge branch 'CCExtractor:main' into github_actions
devansh12b2 Dec 27, 2021
f85bbf9
required changes
devansh12b2 Dec 27, 2021
10bfed6
Merge branch 'github_actions' of https://github.com/devansh12b2/beaco…
devansh12b2 Dec 27, 2021
4a62749
Merge branch 'CCExtractor:main' into github_actions
devansh12b2 Dec 28, 2021
84b50b5
Merge branch 'CCExtractor:main' into github_actions
devansh12b2 Dec 28, 2021
97f8ab8
Merge pull request #1 from devansh12b2/github_actions
devansh12b2 Dec 28, 2021
a73df14
Update README.md
devansh12b2 Dec 28, 2021
88180d7
Merge branch 'github_actions' of https://github.com/devansh12b2/beaco…
devansh12b2 Dec 28, 2021
8d52cc3
Update README.md
devansh12b2 Dec 28, 2021
4c4053b
Merge pull request #2 from devansh12b2/github_actions
devansh12b2 Dec 28, 2021
9c65949
Update README.md
nb9960 Dec 28, 2021
985f719
Merge branch 'CCExtractor:main' into main
devansh12b2 Dec 28, 2021
73454d3
Merge branch 'CCExtractor:main' into github_actions
devansh12b2 Dec 28, 2021
34ef8f2
Merge branch 'CCExtractor:main' into main
devansh12b2 Dec 28, 2021
23628d5
Update README.md
devansh12b2 Dec 28, 2021
dc7a1e4
Merge branch 'CCExtractor:main' into github_actions
devansh12b2 Dec 28, 2021
758195f
Merge branch 'CCExtractor:main' into main
devansh12b2 Dec 28, 2021
803b5b3
Merge branch 'CCExtractor:main' into github_actions
devansh12b2 Dec 28, 2021
3134b06
Update shared_preference_service.dart
devansh12b2 Dec 28, 2021
69f7418
Merge branch 'main' into github_actions
devansh12b2 Dec 28, 2021
87e2b5c
Merge pull request #4 from devansh12b2/github_actions
devansh12b2 Dec 28, 2021
52ef23f
Now if duration is 0:00:00 it will show error
devansh12b2 Dec 28, 2021
ee5f5e0
Merge branch 'CCExtractor:main' into duration_error
devansh12b2 Dec 28, 2021
1b6f539
Merge branch 'CCExtractor:main' into duration_error
devansh12b2 Dec 29, 2021
b9fc9d7
unused imports removed
devansh12b2 Dec 29, 2021
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions lib/components/create_join_dialog.dart
Original file line number Diff line number Diff line change
Expand Up @@ -76,13 +76,13 @@ class CreateJoinBeaconDialog {
.toString()
.substring(0, 8);
},
validator: (value) {
if (value.startsWith("0:00:00"))
return "Enter valid duration";
return null;
},
validator: (value) =>
Validator.validateDuration(
value.toString()),
decoration: InputDecoration(
alignLabelWithHint: true,
errorStyle:
TextStyle(color: Colors.red[800]),
floatingLabelBehavior:
FloatingLabelBehavior.always,
labelText: 'Duration',
Expand Down
1 change: 0 additions & 1 deletion lib/router.dart
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
import 'package:beacon/splash_screen.dart';
import 'package:flutter/cupertino.dart';
import 'package:flutter/material.dart';
import 'package:beacon/utilities/constants.dart';
import 'package:beacon/views/auth_screen.dart';
Expand Down
1 change: 0 additions & 1 deletion lib/services/navigation_service.dart
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
import 'package:flutter/cupertino.dart';
import 'package:flutter/material.dart';

class NavigationService {
Expand Down
7 changes: 7 additions & 0 deletions lib/services/validators.dart
Original file line number Diff line number Diff line change
Expand Up @@ -55,4 +55,11 @@ class Validator {
}
return null;
}

static String validateDuration(String duration) {
if (duration.startsWith("0:00:00.")) {
return "Duration cannot be $duration";
}
return null;
}
}
1 change: 0 additions & 1 deletion lib/views/auth_screen.dart
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,6 @@ import 'package:beacon/utilities/indication_painter.dart';
import 'package:beacon/view_model/auth_screen_model.dart';
import 'package:beacon/views/base_view.dart';
import 'package:flutter/material.dart';
import 'package:flutter/services.dart';

class AuthScreen extends StatefulWidget {
const AuthScreen({Key key}) : super(key: key);
Expand Down
1 change: 0 additions & 1 deletion lib/views/hike_screen.dart
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
import 'dart:async';
import 'package:beacon/components/hike_button.dart';
import 'package:beacon/queries/beacon.dart';
import 'package:flutter/rendering.dart';
import 'package:flutter/material.dart';
import 'package:flutter_config/flutter_config.dart';
import 'package:fluttertoast/fluttertoast.dart';
Expand Down