Fix auth_test.go, minor err-check in auth_oidc.go

CERIT-SC · Feb 15, 2024 · 5487aa4 · 5487aa4
1 parent bde1d83
commit 5487aa4
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 8 deletions.
diff --git a/server/auth_oidc.go b/server/auth_oidc.go
@@ -159,6 +159,13 @@ func (c *OidcConfig) isJwtActive(token string) bool {
 			c.remote.IntrospectionEndpoint,
 			strings.NewReader(params))
 
+		if err != nil {
+			fmt.Printf("[ERROR] Failed to create a new request for the OIDC "+
+				"introspection endpoint (POST %s): %s\n",
+				c.remote.IntrospectionEndpoint, err)
+			return false
+		}
+
 		request.Header.Set("Content-Type", "application/x-www-form-urlencoded")
 
 		if c.local.ClientId != "" && c.local.ClientSecret != "" {

diff --git a/tests/auth/auth_test.go b/tests/auth/auth_test.go
@@ -33,26 +33,26 @@ func TestBasicAuthFail(t *testing.T) {
 		Id:   "1",
 		View: tes.TaskView_MINIMAL,
 	})
-	if err == nil || !strings.Contains(err.Error(), "STATUS CODE - 403") {
+	if err == nil || !strings.Contains(err.Error(), "STATUS CODE - 401") {
 		t.Fatal("expected error")
 	}
 
 	_, err = fun.HTTP.ListTasks(ctx, &tes.ListTasksRequest{
 		View: tes.TaskView_MINIMAL,
 	})
-	if err == nil || !strings.Contains(err.Error(), "STATUS CODE - 403") {
+	if err == nil || !strings.Contains(err.Error(), "STATUS CODE - 401") {
 		t.Fatal("expected error")
 	}
 
 	_, err = fun.HTTP.CreateTask(ctx, extask)
-	if err == nil || !strings.Contains(err.Error(), "STATUS CODE - 403") {
+	if err == nil || !strings.Contains(err.Error(), "STATUS CODE - 401") {
 		t.Fatal("expected error")
 	}
 
 	_, err = fun.HTTP.CancelTask(ctx, &tes.CancelTaskRequest{
 		Id: "1",
 	})
-	if err == nil || !strings.Contains(err.Error(), "STATUS CODE - 403") {
+	if err == nil || !strings.Contains(err.Error(), "STATUS CODE - 401") {
 		t.Fatal("expected error")
 	}
 
@@ -61,26 +61,26 @@ func TestBasicAuthFail(t *testing.T) {
 		Id:   "1",
 		View: tes.TaskView_MINIMAL,
 	})
-	if err == nil || !strings.Contains(err.Error(), "PermissionDenied") {
+	if err == nil || !strings.Contains(err.Error(), "Unauthenticated") {
 		t.Fatal("expected error")
 	}
 
 	_, err = fun.RPC.ListTasks(ctx, &tes.ListTasksRequest{
 		View: tes.TaskView_MINIMAL,
 	})
-	if err == nil || !strings.Contains(err.Error(), "PermissionDenied") {
+	if err == nil || !strings.Contains(err.Error(), "Unauthenticated") {
 		t.Fatal("expected error")
 	}
 
 	_, err = fun.RPC.CreateTask(ctx, tests.HelloWorld())
-	if err == nil || !strings.Contains(err.Error(), "PermissionDenied") {
+	if err == nil || !strings.Contains(err.Error(), "Unauthenticated") {
 		t.Fatal("expected error")
 	}
 
 	_, err = fun.RPC.CancelTask(ctx, &tes.CancelTaskRequest{
 		Id: "1",
 	})
-	if err == nil || !strings.Contains(err.Error(), "PermissionDenied") {
+	if err == nil || !strings.Contains(err.Error(), "Unauthenticated") {
 		t.Fatal("expected error")
 	}