Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for unit tests and golangci-lint #4

Merged
merged 12 commits into from
Feb 29, 2024
Merged

Conversation

mrtamm
Copy link

@mrtamm mrtamm commented Feb 27, 2024

This PR contains minor fixes to unit tests and the golangci-lint configuration. However, it does not cover the issues reported by the linter (to keep this PR small).

Unit tests:

  1. storage tests: provided valid Google Storage URL for testing download
  2. storage tests: fixed configuration tests that failed as htsget configuration was not explicitly disabled
  3. core test: added more precise logging as the test occasionally failed (but not anymore)

golangci-lint:

  1. had to upgrade some go dependencies and go version (to 1.21) as the linter failed to handle some dependencies properly, and thus failed.
  2. also updated other GitHub actions.

Follow-up actions after this PR as separate PRs:

  1. fix problems reported by the linter
  2. upgrade dependencies

@mrtamm
Copy link
Author

mrtamm commented Feb 27, 2024

Here is the current status of the GitHub actions workflow: https://github.com/mrtamm/funnel-gdi/actions/runs/8067628969

@xhejtman xhejtman merged commit 522eac9 into CERIT-SC:master Feb 29, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants