-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DeckLink] timestamp restart on format change #347
Comments
affects c1a1f83, 64ecc16 Now audio frames are discarded unless if video signal is not detected, this doesn't affect situations when just the audio frame is passed. This refers to GH-347, because it drops the audio frames that are produced prior signal is detected. Calling IDeckLinkInput::EnableVideoInput restart timestamps.
This issue shouldn't now occur now (since 5e2815c) when UG starts. It still does when format changes, because DeckLink resets timestaps when IDeckLinkInput::EnableVideoInput() is called (needs to be called with the new format). Since the timestamp discontinuity doesn't seem to be producing issues (aside the warning), I am considering not solving that. It is perhaps not possible to persuade the BMD API not the reset the timer so it will require to "remember" the offset and adding it to the timestamp from device. |
Agreed. Apart from the warning, doesn't seem to actually be creating any negative behavior. |
When format change occurs, timestamps are reset causing libopus warning:
Steps to reproduce:
When there is format auto-detection, at least on the beginning this occurs once (if using auto-detection). Not sure if this causes some problems now (but possible with DeckLink sync output).
The text was updated successfully, but these errors were encountered: