Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update/students #232

Merged
merged 32 commits into from
Sep 16, 2024
Merged

Update/students #232

merged 32 commits into from
Sep 16, 2024

Conversation

JoshuaTristanWereley
Copy link
Contributor

Pull Request

Description:

I have updated the styling across several areas: authentication, lessons table, and material page.

For authentication, I’ve introduced a glassmorphic effect on the landing page, complete with a background animation. The page is now fully responsive, ensuring optimal performance across all devices. Additionally, the light and dark modes are automatically adjusted based on the user’s system settings. These enhancements have also been applied to the Sign In page, and the Sign Up page has been made responsive.

The lessons table has been redesigned for improved contrast and readability in both light and dark modes. I’ve also added a search feature to help users navigate through numerous lessons more efficiently.

The material page has undergone a complete overhaul, now offering a more polished appearance in dark mode and eliminating the grey bars adjacent to the PDF preview. Additionally, hovering over a 3D object now renders a live preview of the object.

Related Issues:

  • Although I have made Sign In responsive, I still need to add similar styling that I have used for the landing page and sign up.
  • I need to adjust the sizing of the image in sign up.
  • I need to replace the Image Placeholder in the lessons table with the actual data of the lesson.
  • I need to add edit button for both live lessons and up coming lessons.
  • I have left out quizzes code.

Type of Change:

  • Bug Fix
  • New Feature
  • Enhancement
  • Refactoring
  • Documentation Update

Additional Notes:

N/A

Copy link

codecov bot commented Sep 12, 2024

Codecov Report

Attention: Patch coverage is 47.98928% with 388 lines in your changes missing coverage. Please review.

Project coverage is 26.11%. Comparing base (2cad04b) to head (1e3bc3d).
Report is 33 commits behind head on develop.

Files with missing lines Patch % Lines
...c/src/lib/components/materials/MaterialsTab.svelte 0.00% 88 Missing ⚠️
...(app)/workspaces/[workspace]/quizzes/Canvas.svelte 0.00% 56 Missing ⚠️
.../(app)/workspaces/[workspace]/quizzes/+page.svelte 0.00% 45 Missing ⚠️
src/src/routes/+page.svelte 0.00% 44 Missing ⚠️
.../(app)/workspaces/[workspace]/lessons/+page.svelte 0.00% 37 Missing ⚠️
src/src/lib/components/common/Navbar.svelte 0.00% 34 Missing ⚠️
...app)/workspaces/[workspace]/quizzes/Palette.svelte 0.00% 29 Missing ⚠️
src/src/lib/components/common/Header.svelte 0.00% 27 Missing ⚠️
src/src/lib/components/common/SideBar.svelte 0.00% 21 Missing ⚠️
src/src/routes/(app)/+layout.svelte 0.00% 2 Missing ⚠️
... and 4 more
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #232      +/-   ##
===========================================
+ Coverage    25.49%   26.11%   +0.61%     
===========================================
  Files          187      190       +3     
  Lines         8914     9356     +442     
  Branches       456      472      +16     
===========================================
+ Hits          2273     2443     +170     
- Misses        6641     6913     +272     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@ayandajuqu ayandajuqu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@bukhosi-eugene-mpande bukhosi-eugene-mpande merged commit d774917 into develop Sep 16, 2024
6 checks passed
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment