Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update/profile #234

Merged
merged 11 commits into from
Sep 11, 2024
Merged

Update/profile #234

merged 11 commits into from
Sep 11, 2024

Conversation

bukhosi-eugene-mpande
Copy link
Contributor

@bukhosi-eugene-mpande bukhosi-eugene-mpande commented Sep 10, 2024

Pull Request

Description:
Update to profile page
Updated upload
Updated tests

Related Issues:

Type of Change:

  • Bug Fix
  • New Feature
  • Enhancement
  • Refactoring
  • Documentation Update

Additional Notes:

[Any additional information that may be helpful for reviewers.]

Copy link
Contributor

@Lunga-Ntando-Ndlovu Lunga-Ntando-Ndlovu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes seem decent, and it seems that there is no conflict

Copy link
Contributor

@ayandajuqu ayandajuqu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@bukhosi-eugene-mpande bukhosi-eugene-mpande merged commit 2f00b36 into develop Sep 11, 2024
6 checks passed
Copy link

codecov bot commented Sep 11, 2024

Codecov Report

Attention: Patch coverage is 29.31034% with 492 lines in your changes missing coverage. Please review.

Project coverage is 23.78%. Comparing base (31bff04) to head (51517e0).
Report is 12 commits behind head on develop.

Files with missing lines Patch % Lines
src/src/lib/utils/index.ts 0.00% 108 Missing ⚠️
src/src/lib/server/utils/profile.ts 0.00% 82 Missing ⚠️
src/src/routes/api/upload/+server.ts 0.00% 54 Missing ⚠️
src/src/lib/server/utils/material.ts 0.00% 44 Missing ⚠️
src/src/lib/server/UploadHandler.ts 0.00% 42 Missing ⚠️
...components/modals/materials/PreviewMaterial.svelte 0.00% 39 Missing ⚠️
src/src/lib/server/storage.ts 8.69% 21 Missing ⚠️
src/src/lib/server/utils/lessons.ts 80.00% 20 Missing ⚠️
.../src/lib/components/lessons/lesson/Controls.svelte 0.00% 15 Missing ⚠️
src/src/lib/components/common/Header.svelte 0.00% 14 Missing ⚠️
... and 7 more
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #234      +/-   ##
===========================================
+ Coverage    20.26%   23.78%   +3.51%     
===========================================
  Files          181      187       +6     
  Lines         8657     8839     +182     
  Branches       417      437      +20     
===========================================
+ Hits          1754     2102     +348     
+ Misses        6903     6737     -166     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants