Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependencies not included in package #476

Closed
ss2165 opened this issue Jul 12, 2024 · 1 comment · Fixed by #477
Closed

Dependencies not included in package #476

ss2165 opened this issue Jul 12, 2024 · 1 comment · Fixed by #477
Assignees
Labels
bug Something isn't working ci CI / devops python Pull requests that update Python code

Comments

@ss2165
Copy link
Member

ss2165 commented Jul 12, 2024

Originally reported by @sjdilkes
The wheels being built are not including dependencies. This is probably because the dependencies are only under the poetry tool section of pyproject.toml. They may need to be duplicated. Is there a way that avoids duplication?

@ss2165 ss2165 added the bug Something isn't working label Jul 12, 2024
@aborgna-q aborgna-q self-assigned this Jul 12, 2024
@aborgna-q aborgna-q added ci CI / devops python Pull requests that update Python code labels Jul 12, 2024
@aborgna-q
Copy link
Collaborator

Short resume of various issues:

So in short; we'll have to duplicate things for now :/

github-merge-queue bot pushed a commit that referenced this issue Jul 12, 2024
Fixes #476 

This is an annoying duplication due to poetry not following PEP 631 and
reading dependencies from `[project.dependencies]`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ci CI / devops python Pull requests that update Python code
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants