Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate unit tests to xUnit #11

Closed
CXuesong opened this issue Jul 10, 2017 · 4 comments
Closed

Migrate unit tests to xUnit #11

CXuesong opened this issue Jul 10, 2017 · 4 comments
Assignees
@CXuesong
Milestone
v0.6.0

Comments

@CXuesong
Copy link
Owner

… which enables some real asynchronous test methods.
@CXuesong CXuesong self-assigned this Jul 10, 2017
@CXuesong
Copy link
Owner Author

Migration is nearly complete. However, the concurrent execution of unit tests exposed some inconsistency problem, especially, assertion fails in Site.LoginAsync.

The absence of Assert.Inconclusive is also a little bit troublesome…

@CXuesong CXuesong added this to the v0.6.0 milestone Jul 11, 2017
@CXuesong
Copy link
Owner Author

A strange behavior revealed!

I have two WikiClients, A & B. Login to the endpoint X with A, login to the endpoint X with B, and logout from X with B; then we will surprisingly find out we've been logged out from X with A!

It might be MW's security precaution… Anyway, I'm trying to confirm this on Phabricator.

CXuesong added a commit that referenced this issue Jul 12, 2017
@CXuesong
#11 Migrate unit tests to xUnit.
b004763 
The interlacing login/logout issue is yet to be solved.
@CXuesong
Copy link
Owner Author

It's already confirmed in T51890.

It seems that I'm the latest victim. Hooray 😂

CXuesong added a commit that referenced this issue Sep 1, 2017
@CXuesong
Workaround for #11. Serialize unit test execution.
9c4311b
@CXuesong
Copy link
Owner Author

Thus, for now the unit tests are asynchronous yet serial. Anyway the migration is done.

CXuesong added a commit that referenced this issue Sep 22, 2017
@CXuesong
#11 Use [SkippableFact] to take over UnitTestProject1.Inconclusive .
fc78f9d 
Run tests with dotnet xunit.
@CXuesong CXuesong mentioned this issue Jul 28, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@CXuesong CXuesong

Labels
None yet
Projects
None yet
Milestone
v0.6.0
Development

No branches or pull requests
1 participant
@CXuesong