DeleteAsync and MoveAsync fail if Site.Logger is null, AND ModificationThrottler will hang for all further requests

[mikeclist]

1. These async methods fail if Site.Logger is null
   Site.Logger.Info(this, $"Page {title} has been deleted."); // assumes that Site.Logger is not null
   Site.Logger?.Info(this, $"Page {title} has been deleted."); // should be implemented as shown to the left (2 locations)

2. If a task fails, the task is not marked as completed.
   The ModificationThrottler for the next task will wait for the previous task to complete.
   As the failed task will never complete, ModificationThrottler will be in an endless hang.

[CXuesong]

Okay this Logger?. thing is really error-prone, so now I consider using Microsoft.Extensions.Logging for logging.

And Oops I forgot to Dispose the returned value of Site.ModificationThrottler.QueueWorkAsync so virtually it will hang regardless of the operation is successful or not.

Will fix them before tomorrow.

[CXuesong]

Published pre-release: 0.6.0-int2. Hope it solves the problem 😄 The logging interface is kept for now, but may be removed in the future.

[CXuesong]

I'm going to close the issue for now. If the problem still exists, please re-open it :-)

[mikeclist]

I must say this was a very fast turn around to incorporate the fix, almost immediately I lodged the comment. Thank you for your high quality project :)

[CXuesong]

Thanks, Mike. I'm glad you like it!