Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SiteInfo.MagicWords is not filled by anything #89

Closed
stjohann opened this issue Sep 16, 2021 · 1 comment
Closed

SiteInfo.MagicWords is not filled by anything #89

stjohann opened this issue Sep 16, 2021 · 1 comment
Assignees
Milestone

Comments

@stjohann
Copy link
Contributor

While SiteInfo.MagicWords is present and public, it never gets filled by anything since standard API requests from the library do not contain magicwords property in their response. It should be marked as private if this is intended, or fixed (by adding |magicwords to request) if it was not.

Example:
https://en.wikipedia.org/w/api.php?action=query&meta=siteinfo&siprop=general|namespaces|namespacealiases|interwikimap|extensions

(In general, it would have been better to be able to pick and choose these properties yourself, but I think I’ll eventually have to move away from standard SiteInfo, so not a huge deal.)

@CXuesong CXuesong self-assigned this Sep 16, 2021
@CXuesong CXuesong added this to the v0.8.0 milestone Sep 16, 2021
CXuesong added a commit that referenced this issue Sep 24, 2021
Removed the defunct SiteInfo.MagicWords property.
@CXuesong
Copy link
Owner

Released in v0.8.0-int.5.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants