Add MyWatchlistGenerator #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CXuesong
reviewed
Aug 28, 2023
| { | ||
| {"wrnamespace", NamespaceIds == null ? null : MediaWikiHelper.JoinValues(NamespaceIds)}, | ||
| {"wrlimit", PaginationSize}, | ||
| {"wrprop", ShowChangedTime ? "changed" : null}, |
There was a problem hiding this comment.
- I think you can always enable
ShowChangedTime(and remove theShowChangedTimeproperty), if you need it. I guess it does not increase much sever cost. - Since there is custom field (
ChangedTime), you may want to set up a wiki list item type (likeGeoSearchResultItem) and override theWikiPageGenerator<TItem>.ItemFromJsonmethod, so thatWikiPageGenerator<TItem>.EnumItemsAsynccan enumerate something containing aPageStuband aChangedTime, rather thanPageStubonly. You can refer toGeoSearchGeneratoras an example. (Or you can just leave this work to me 😂)
There was a problem hiding this comment.
@CXuesong. {{Done}} :)
I don't like that I hardcoded the value in FindQueryResponseItemsRoot but I couldn't find other lists that give results in a different format (I tested on Armenian Wikipedia).
There was a problem hiding this comment.
Thanks!
I don't like that I hardcoded the value in FindQueryResponseItemsRoot but I couldn't find other lists that give results in a different format (I tested on Armenian Wikipedia).
I guess this is the first time I discover a query result without query JSON root node. Yeah probably we can go without any generic root-finding-function for now, and see what happens.
…kiPageGenerator to WikiPageGenerator<MyWatchlistResultItem>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A new page generator to get pages from logged-in user's watchlist.
I'm not quite sure if the generator is within the scope of this project but I had to create it for my project and thought it could be useful here too.