Revision IDs need to be long everywhere #113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In df21c73, revision IDs have been changed to 64-bit longs, which is now necessary on Wikidata. However, wrong explicit `(int)` casts remained in the code at multiple places, causing exceptions. Fixes CXuesong#112
CXuesong
approved these changes
Jun 10, 2024
|
Thanks for the PR! However, note that master branch has dropped support on .NET Standard 2.1 (#108). If you need support on prior SDK versions, we'll need to also cherry-pick this back to v0.8 branch. |
|
Released |
Nope, I’m fine with the current SDK, thanks! |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In df21c73, revision IDs have been changed to 64-bit longs, which is now necessary on Wikidata. However, wrong explicit
(int)casts remained in the code at multiple places, causing exceptions.Fixes #112