Add binary gltf support (.glb) #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@julianstirling Thanks, I think we will need to add a test for this, even if it is only checking error codes and for the existence of the file. https://github.com/CadQuery/cq-cli/blob/main/tests/test_gltf_codec.py |
|
@julianstirling The linter is complaining about extra lines at the end of the file. I tested your branch with a stereoscope assembly that I have on my system and it works well. Thanks. |
|
Linter fixes pushed |
|
Great, thanks. It's merged into main now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding glb support as no codec existed. It is in a new module rather than in the existing gltf one as I couldn't see how to make it work in the existing one.