Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix magic completion #269

Merged
merged 1 commit into from
Aug 29, 2023
Merged

Fix magic completion #269

merged 1 commit into from
Aug 29, 2023

Conversation

dsblank
Copy link
Member

@dsblank dsblank commented Aug 29, 2023

This PR fixes an edge case in magic completions:

Currently:

If you press TAB after % or %% and select an item it doubles the percents

Example:

%<TAB> and select, say, %cd you'll get %%cd

After PR:

If you press TAB after % or %% and select an item it properly gives selection

Example:

%<TAB> and select, say, %cd you'll get %cd

@dsblank dsblank requested a review from blink1073 August 29, 2023 12:09
@dsblank dsblank added the bug label Aug 29, 2023
Copy link
Contributor

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@blink1073 blink1073 merged commit 26f1a86 into main Aug 29, 2023
18 checks passed
@blink1073 blink1073 deleted the dsb-fix-magic-completion branch August 29, 2023 13:56
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants