Build Nuget package for the .NET interface #1596
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
burkenyo
force-pushed
the
dotnet-interface
branch
6 times, most recently
from
1ec249c
to
df237c4
Compare
Previously, it relied on string matching and StackTrace.ToString() implementation detail that omits methods with the MethodImplOptions.AggressiveInlining flag. The new version looks at the method itself and makes it explicit under what conditions it might not have been inlined yet the test should still pass.
This avoids needing to have all objects created via factory methods in the Application class.
This will facilitate pulling the readme file directly into packages, i.e. the Nuget package
burkenyo
force-pushed
the
dotnet-interface
branch
from
df237c4
to
3489b82
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1596 +/- ##
==========================================
- Coverage 70.61% 70.55% -0.06%
==========================================
Files 379 380 +1
Lines 59153 59222 +69
Branches 21252 21252
==========================================
+ Hits 41768 41785 +17
- Misses 14311 14363 +52
Partials 3074 3074 ☔ View full report in Codecov by Sentry. |
burkenyo
force-pushed
the
dotnet-interface
branch
from
45d1009
to
e19bd47
Compare
Due to an idiosyncrasy in the native lib, separate loggers are created per thread. We need all tests that call the native lib to be on the same thread to ensure the LogWriter_MessageLogged test passes.
burkenyo
force-pushed
the
dotnet-interface
branch
from
294c965
to
689266a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nuget packages are the standard way to share .NET libraries (called assemblies). This change allows us to release the preview .NET interface on Nuget
WIP
Changes proposed in this pull request
If applicable, fill in the issue number this pull request is fixing
Closes #
If applicable, provide an example illustrating new features this pull request is introducing
Checklist
scons build&scons test) and unit tests address code coverage