Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

No support for stake script rewards #277

Closed
klntsky opened this issue Oct 24, 2022 · 2 comments
Closed

No support for stake script rewards #277

klntsky opened this issue Oct 24, 2022 · 2 comments
Labels
help welcomed Good for newcomers server Issues which regard the server
Milestone
v5.7.0

Comments

@klntsky
Copy link

klntsky commented Oct 24, 2022 •
edited
Loading

Describe what the problem is?

It looks like Ogmios only support querying stake rewards for PubKey hashes, there's no ScriptHash support:

  1. ogmios/server/src/Ogmios/Data/Json/Query.hs

    Line 904 in 7a03960

    credentials <- decodeCredentials obj

  2. ogmios/server/src/Ogmios/Data/Json/Query.hs

    Line 1589 in 7a03960

    fmap (Ledger.KeyHashObj . Ledger.KeyHash) . decodeHash
  3. https://github.com/input-output-hk/cardano-ledger/blob/9a25a43f3970941a2cd64029f7ce667b48832635/libs/cardano-ledger-core/src/Cardano/Ledger/Credential.hs#L73

What should be the expected behavior?

We need this kind of query to work with script hashes as well for CTL.
@klntsky klntsky mentioned this issue Oct 24, 2022
Closed
@KtorZ
Copy link
Member

KtorZ commented Oct 24, 2022

Indeed, as indicated in the note here:

ogmios/server/src/Ogmios/Data/Json/Query.hs

Line 1578 in 7a03960

-- TODO: Makes it possible to distinguish between KeyHash and ScriptHash

So, bech32 will likely come at the rescue here.

@KtorZ KtorZ added this to the v5.7.0 milestone Oct 25, 2022
@KtorZ KtorZ added help welcomed Good for newcomers server Issues which regard the server labels Oct 25, 2022
@KtorZ
Copy link
Member

KtorZ commented Oct 27, 2022

Closed in 1495b4f

@KtorZ KtorZ closed this as completed Oct 27, 2022
klntsky added a commit to klntsky/ogmios that referenced this issue Oct 31, 2022
@klntsky
Merge tag 'v5.5.7' of github.com:CardanoSolutions/ogmios into klntsky…
1c8cc39 
…/ogmios-v5.5.7

v5.5.7

  #### Added

  - `delegationAndRewards` and `nonMyopicMemberRewards` queries now both accept credentials in the form of bech32 strings as parameters, with the following expected prefixes and semantic (according to [CIP-0005](https://github.com/cardano-foundation/CIPs/tree/master/CIP-0005#specification):

    - `stake` (resp. `stake_test` on test networks) for stake addresses
    - `stake_vkh` for stake key hash digests
    - `script` for stake script hash digests

    See also [CardanoSolutions#277](CardanoSolutions#277).

  - ![TypeScript][] Allow `additionalUtxoSet` to be passed as argument in the repl.

  #### Changed

  - ![TypeScript][] Fixed `additionalUtxoSet` being ignored in the `TxSubmissionClient` of the TypeScript client.

  #### Removed

  N/A
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help welcomed Good for newcomers server Issues which regard the server
Projects
None yet
Milestone
v5.7.0
Development

No branches or pull requests
2 participants
@KtorZ @klntsky