New typography toolkit for MUI carto-theme #498
Conversation
| lineHeight: 1.428, | ||
| letterSpacing: 0 | ||
| }, | ||
| codeMediumStrong: { |
There was a problem hiding this comment.
If we're gonna go after several 'nested' concepts here, should we create a proper object (to use keyed names)?
I'm thinking about something similar to (pseudo-code):
code : {
default: { /* style definition */ }
large: {
default: { /*whatever*/}
strong: { ... }
}
}
So we would consume externally something like: code.large.strong
Also I'm feeling that this set of custom elements could be maybe separated from official typography in the tree, having like a first level with custom : { /* previous keys here */ } Would it be too verbose? or complex? What do you think?
There was a problem hiding this comment.
Good point. I like what you're proposing about nesting, I'll give it a try.
| ...baseTypography, | ||
| ...customTypography |
There was a problem hiding this comment.
I'm not sure about including both blocks at the same level... but probably we can move on and have a longer discussion
|
@VictorVelarde I added some comments and cleaned up the number of variants a bit, based on our discussion and the meeting I had with the design team earlier. We have an open issue in shortcut to improve the props/variants management, that we can address after we do the MUI update. Once this is done, we will be able to remove most of the new custom variants added. |
Description
New typography toolkit for MUI carto-theme and added several custom variants.
Type of change