-
Notifications
You must be signed in to change notification settings - Fork 941
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial Development Commit #4
Conversation
I don't really know where to start with this but here goes, there is a MAJOR amount of work still required to bring RawPhone even close to what is hoped for but I think this gives a solid base to start with even if it is still very rough! :) This commit makes a number of significant changes to the original base RawPhone application each of which will be explained in detail below IF I can remember them all... 1. Device information was split into a new class to allow easy modifications in the future, all items such as IMEI, Operator etc are now contained within this class. 2. RootTools library added to provide access to helper functions such as checking for the provision of root, and offering installation of BusyBox if it is not detected. 3. CMDProcessor - The AOKP CMDProcessor has been added to RawPhone allowing shell commands and various helper functions to be executed, I find this library to be very stable and it works very well. Some items already added with this include checking for Busybox installation and the util Microcom which should allow some form of serial communication on the device (NOT TESTED YET!). 4. Microcom applet - This is an applet available through Busybox which has been included and RawPhone will prompt to install this if it is not located, initial reading regarding this points to the fact it is supposed to allow for the issuing of basic AT serial commands ON THE DEVICE. Very interesting indeed but as yet this is untested as I have not written the methods to issue the AT commands using the applet. 5. Initial changes have also been made for a revamp of the UI but as yet this has not been implemented.
Awesome, thank you very much! I reviewed your initial development commit, yet I am waiting for some feedback of my development partner @E3V3A. There are still some basic things we need to clarify. Cool to have ya rumblin' with us, send me your address via PM on XDA if you'd like to receive a present (my promise from Issue #2)! ;-) |
Just pushed a work in progress commit which is a start for the oem ril test code, I am playing around with reflection to access the required methods. Have to go to bed but I will look at this more tomorrow. |
@xLaMbChOpSx, thank you very much for your eager contributions! Sadly, I did not get in touch with @E3V3A in the past few weeks and would like him to review your commits first. Please be patient, development will continue soon. THANK YOU! |
WORK IN PROGRESS Initial commit for the OEMRILTEST code utilising hidden Telephony API's for use of the OEM_RIL methods, hopefully this will provide a device independant method for sending AT Commands to a device and receiving the response. Added a cut down version of the frameworks_base classes file to access the hidden AsyncResult class and telephony_common classes file to access the hidden Phone & Phonefactory classes. Major Android Code Style cleanup of entire code base, include resources.
Included partial OemCommands class as found in the SamsungServiceMode application which has allowed for activating the Ciphering Indicator RIL response, although this is specific to Samsung it does at least pave the way for further commands and this interface uses the invokeOemRilRequestRaw method. Use of this method has required the reapplication of the frameworks libs to allow access to the hidden APIs contained within the SDK, the relfection methods have not been removed as they will still probably be very useful. Extensive changes have also been made to the manifest to allow the application to share the com.android.phone process, this also requires the signing of the application with the SDK platform key. As signing is required from this point forward I will attach a new github release apk to match the commits pushed, this will hopefully allow for easy testing as people will not need at import/sign with the platform keys.
Hey @xLaMbChOpSx, first of all: It is my honor to have you here and to know you are as eager as I am to get the party started! ;-) Due to the fact that our main developer and project starter @E3V3A has not been getting back in touch with me since several weeks after he told me he'll visit a rather dangerous country, I was very concerned about his well-being - until 3 days ago when I noticed he starred a project on GitHub. Sadly, he is not responding to all my messages and have to assume he is greedy or busy with something he's not yet ready to tell me (@E3V3A, please tell me what's going on - I'll sponsor you a beer! C'mon!). To get to the point: At this very moment I am let alone on this project and clearly lack the competence of properly reviewing the changes you made to the RawPhone source code. But that does not mean that you didn't create an awesome contribution! The only thing I noticed which doesn't fit our development "style guide" is that you commited the changes to be applied on folder 'MERGESOURCE', which is solely meant to be a place to drop the clear and unchanged source of applications to integrate into our app one day. With that being clarified, may I kindly ask you to submit new commits where these things are met:
I admit it: It's shitty we haven't added any files of RawPhone in the main directory to be worked with in the first place. We simply did not know what was needed (yet), and without any instruction from @E3V3A (whose project this really is from the first day on), I am being put on a hard and stony path to walk bare feet on. I am truly sorry having to neglect your great commits now and apologize for any inconvenience or coding issues this may cause to you now. But please, stay with me, don't give up and submit new commits as mentioned above, as a reward I will make sure to add you as an official contributor. Promised! |
Hi SecUpwN,
I posted on the xda thread with some info and below is the commit message regarding the initial commit I am pushing here for your review. :)
I don't really know where to start with this but here goes, there is a
MAJOR amount of work still required to bring RawPhone even close to what is
hoped for but I think this gives a solid base to start with even if it is still
very rough! :)
This commit makes a number of significant changes to the original base
RawPhone application each of which will be explained in detail below IF
I can remember them all...
in the future, all items such as IMEI, Operator etc are now contained within
this class.
checking for the provision of root, and offering installation of BusyBox if
it is not detected.
shell commands and various helper functions to be executed, I find this library
to be very stable and it works very well. Some items already added with this
include checking for Busybox installation and the util Microcom which should
allow some form of serial communication on the device (NOT TESTED YET!).
included and RawPhone will prompt to install this if it is not located, initial
reading regarding this points to the fact it is supposed to allow for the
issuing of basic AT serial commands ON THE DEVICE. Very interesting indeed but
as yet this is untested as I have not written the methods to issue the AT
commands using the applet.
has not been implemented.