Skip to content

Commit

Permalink
Rollup merge of rust-lang#67559 - Mark-Simulacrum:drop-doc, r=RalfJung
Browse files Browse the repository at this point in the history
Document that calling Drop, even after it panics, is UB

Fixes rust-lang#60822.

r? @gnzlbg
  • Loading branch information
Centril committed Dec 23, 2019
2 parents 7eb025f + a08df28 commit 68a9a2d
Showing 1 changed file with 6 additions and 0 deletions.
6 changes: 6 additions & 0 deletions src/libcore/ops/drop.rs
Original file line number Diff line number Diff line change
Expand Up @@ -99,9 +99,15 @@ pub trait Drop {
/// Given that a [`panic!`] will call `drop` as it unwinds, any [`panic!`]
/// in a `drop` implementation will likely abort.
///
/// Note that even if this panics, the value is considered to be dropped;
/// you must not cause `drop` to be called again. This is normally automatically
/// handled by the compiler, but when using unsafe code, can sometimes occur
/// unintentionally, particularly when using [`std::ptr::drop_in_place`].
///
/// [E0040]: ../../error-index.html#E0040
/// [`panic!`]: ../macro.panic.html
/// [`std::mem::drop`]: ../../std/mem/fn.drop.html
/// [`std::ptr::drop_in_place`]: ../../std/ptr/fn.drop_in_place.html
#[stable(feature = "rust1", since = "1.0.0")]
fn drop(&mut self);
}

0 comments on commit 68a9a2d

Please sign in to comment.