fix error validation on ed25519

ChainSafe · Dec 1, 2021 · 1ee5e82 · 1ee5e82
1 parent f223d65
commit 1ee5e82
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 5 deletions.
diff --git a/lib/crypto/ed25519/ed25519.go b/lib/crypto/ed25519/ed25519.go
@@ -53,10 +53,8 @@ func VerifySignature(publicKey, signature, message []byte) error {
 
 	ok, err := pubKey.Verify(message, signature)
 	if err != nil {
-		return fmt.Errorf("ed25519: %w: %s", crypto.ErrSignatureVerificationFailed, err)
-	}
-
-	if !ok {
+		return fmt.Errorf("ed25519: %w", err)
+	} else if !ok {
 		return fmt.Errorf("ed25519: %w: for message 0x%x, signature 0x%x and public key 0x%x",
 			crypto.ErrSignatureVerificationFailed, message, signature, publicKey)
 	}

diff --git a/lib/crypto/ed25519/ed25519_test.go b/lib/crypto/ed25519/ed25519_test.go
@@ -131,7 +131,7 @@ func TestVerifySignature(t *testing.T) {
 			publicKey: keypair.public.Encode(),
 			signature: []byte{},
 			message:   message,
-			err:       fmt.Errorf("ed25519: %w: invalid signature length", crypto.ErrSignatureVerificationFailed),
+			err:       fmt.Errorf("ed25519: invalid signature length"),
 		},
 		"verification failed": {
 			publicKey: keypair.public.Encode(),