Skip to content

Commit

Permalink
fix(ci): run golangci-lint on integration tests (#2275)
Browse files Browse the repository at this point in the history
- Use `Makefile` lint target
- Add `--build-tags integration` to Makefile lint command
- Add ` --timeout 10m` to Makefile lint command
  • Loading branch information
qdm12 committed Feb 8, 2022
1 parent d1308e0 commit 3ae3401
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 8 deletions.
9 changes: 2 additions & 7 deletions .github/workflows/checks.yml
Original file line number Diff line number Diff line change
Expand Up @@ -25,14 +25,9 @@ jobs:
- uses: actions/setup-go@v2
with:
go-version: "1.17.x"
- uses: actions/checkout@v2

- name: setup golangci-lint
run: |
curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh |
sh -s -- -b $(go env GOPATH)/bin v1.43.0

- run: golangci-lint run --timeout 10m
- name: Lint
run: make lint

check-description:
name: Checks PR has title and body description
Expand Down
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ help: Makefile
.PHONY: lint
lint:
go install github.com/golangci/golangci-lint/cmd/golangci-lint@v1.43.0
golangci-lint run
golangci-lint run --build-tags integration --timeout 10m

clean:
rm -fr ./bin
Expand Down

0 comments on commit 3ae3401

Please sign in to comment.