fix(lint): fix issues found by golangcilint 1.47.3 (#2715)

- Fix issues caused by fixed `tparallel`
- Fix issues caused by fixed `lll`
- Add exclude rules for `lll` for C imports

.golangci.yml

@@ -103,6 +103,16 @@ issues:
         - lll
       source: "^//go:generate "
 
+    - linters:
+        - lll
+      path: lib/runtime/wasmer/imports\.go
+      source: "^// extern "
+
+    - linters:
+        - lll
+      path: lib/runtime/wasmer/imports\.go
+      source: '{"ext_.+", ext_.+, C.ext_.+},$'
+
     - source: "// https://"
       linters:
         - lll

dot/import_test.go

@@ -107,7 +107,10 @@ func TestImportState(t *testing.T) {
 		},
 	}
 	for _, tt := range tests {
+		tt := tt
 		t.Run(tt.name, func(t *testing.T) {
+			t.Parallel()
+
 			err := ImportState(tt.args.basepath, tt.args.stateFP, tt.args.headerFP, tt.args.firstSlot)
 			if tt.err != nil {
 				assert.EqualError(t, err, tt.err.Error())
@@ -175,7 +178,10 @@ func Test_newHeaderFromFile(t *testing.T) {
 		},
 	}
 	for _, tt := range tests {
+		tt := tt
 		t.Run(tt.name, func(t *testing.T) {
+			t.Parallel()
+
 			got, err := newHeaderFromFile(tt.filename)
 			if tt.err != nil {
 				assert.EqualError(t, err, tt.err.Error())
@@ -208,7 +214,10 @@ func Test_newTrieFromPairs(t *testing.T) {
 		},
 	}
 	for _, tt := range tests {
+		tt := tt
 		t.Run(tt.name, func(t *testing.T) {
+			t.Parallel()
+
 			got, err := newTrieFromPairs(tt.filename)
 			if tt.err != nil {
 				assert.EqualError(t, err, tt.err.Error())

dot/node_test.go

@@ -91,7 +91,10 @@ func TestLoadGlobalNodeName(t *testing.T) {
 		},
 	}
 	for _, tt := range tests {
+		tt := tt
 		t.Run(tt.name, func(t *testing.T) {
+			t.Parallel()
+
 			gotNodename, err := LoadGlobalNodeName(tt.basepath)
 			if tt.err != nil {
 				assert.EqualError(t, err, tt.err.Error())

dot/services_test.go

@@ -137,9 +137,10 @@ func Test_newInMemoryDB(t *testing.T) {
 //go:generate mockgen -destination=mock_service_builder_test.go -package $GOPACKAGE . ServiceBuilder
 
 func Test_nodeBuilder_createBABEService(t *testing.T) {
+	t.Parallel()
+
 	ctrl := gomock.NewController(t)
 	mockBabeIFace := NewMockServiceIFace(ctrl)
-	t.Parallel()
 
 	cfg := NewTestConfig(t)
 
@@ -204,7 +205,10 @@ func Test_nodeBuilder_createBABEService(t *testing.T) {
 		},
 	}
 	for _, tt := range tests {
+		tt := tt
 		t.Run(tt.name, func(t *testing.T) {
+			t.Parallel()
+
 			stateSrvc := newStateService(t, ctrl)
 			mockBabeBuilder := NewMockServiceBuilder(ctrl)
 			mockBabeBuilder.EXPECT().NewServiceIFace(
@@ -314,7 +318,10 @@ func Test_nodeBuilder_createCoreService(t *testing.T) {
 		},
 	}
 	for _, tt := range tests {
+		tt := tt
 		t.Run(tt.name, func(t *testing.T) {
+			t.Parallel()
+
 			cfg := NewTestConfig(t)
 			ctrl := gomock.NewController(t)
 			stateSrvc := newStateService(t, ctrl)
@@ -351,9 +358,12 @@ func Test_nodeBuilder_createNetworkService(t *testing.T) {
 		},
 	}
 	for _, tt := range tests {
+		tt := tt
 		t.Run(tt.name, func(t *testing.T) {
-			cfg := NewTestConfig(t)
+			t.Parallel()
 			ctrl := gomock.NewController(t)
+
+			cfg := NewTestConfig(t)
 			stateSrvc := newStateService(t, ctrl)
 			no := nodeBuilder{}
 			got, err := no.createNetworkService(cfg, stateSrvc, nil)
@@ -384,7 +394,10 @@ func Test_nodeBuilder_createRPCService(t *testing.T) {
 		},
 	}
 	for _, tt := range tests {
+		tt := tt
 		t.Run(tt.name, func(t *testing.T) {
+			t.Parallel()
+
 			cfg := NewTestConfig(t)
 			ctrl := gomock.NewController(t)
 			stateSrvc := newStateService(t, ctrl)
@@ -435,7 +448,10 @@ func Test_nodeBuilder_createGRANDPAService(t *testing.T) {
 		},
 	}
 	for _, tt := range tests {
+		tt := tt
 		t.Run(tt.name, func(t *testing.T) {
+			t.Parallel()
+
 			cfg := NewTestConfig(t)
 			ctrl := gomock.NewController(t)
 			stateSrvc := newStateService(t, ctrl)
@@ -486,7 +502,10 @@ func Test_createRuntime(t *testing.T) {
 		},
 	}
 	for _, tt := range tests {
+		tt := tt
 		t.Run(tt.name, func(t *testing.T) {
+			t.Parallel()
+
 			ctrl := gomock.NewController(t)
 			stateSrvc := newStateService(t, ctrl)
 			code, err := stateSrvc.Storage.LoadCode(nil)
@@ -534,7 +553,10 @@ func Test_nodeBuilder_newSyncService(t *testing.T) {
 		},
 	}
 	for _, tt := range tests {
+		tt := tt
 		t.Run(tt.name, func(t *testing.T) {
+			t.Parallel()
+
 			cfg := NewTestConfig(t)
 			ctrl := gomock.NewController(t)
 			stateSrvc := newStateService(t, ctrl)

dot/state/grandpa_test.go

@@ -142,7 +142,7 @@ func testBlockState(t *testing.T, db chaindb.Database) *BlockState {
 	return bs
 }
 
-func TestAddScheduledChangesKeepTheRightForkTree(t *testing.T) {
+func TestAddScheduledChangesKeepTheRightForkTree(t *testing.T) { //nolint:tparallel
 	t.Parallel()
 
 	keyring, err := keystore.NewSr25519Keyring()
@@ -217,7 +217,6 @@ func TestAddScheduledChangesKeepTheRightForkTree(t *testing.T) {
 	}
 
 	for tname, tt := range tests {
-		tt := tt
 		t.Run(tname, func(t *testing.T) {
 			// clear the scheduledChangeRoots after the test ends
 			// this does not cause race condition because t.Run without
@@ -566,6 +565,8 @@ func TestNextGrandpaAuthorityChange(t *testing.T) {
 }
 
 func TestApplyForcedChanges(t *testing.T) {
+	t.Parallel()
+
 	keyring, err := keystore.NewSr25519Keyring()
 	require.NoError(t, err)
 
@@ -768,6 +769,8 @@ func TestApplyForcedChanges(t *testing.T) {
 }
 
 func TestApplyScheduledChangesKeepDescendantForcedChanges(t *testing.T) {
+	t.Parallel()
+
 	keyring, err := keystore.NewSr25519Keyring()
 	require.NoError(t, err)
 
@@ -885,6 +888,8 @@ func TestApplyScheduledChangesKeepDescendantForcedChanges(t *testing.T) {
 }
 
 func TestApplyScheduledChangeGetApplicableChange(t *testing.T) {
+	t.Parallel()
+
 	keyring, err := keystore.NewSr25519Keyring()
 	require.NoError(t, err)
 
@@ -1120,6 +1125,8 @@ func TestApplyScheduledChangeGetApplicableChange(t *testing.T) {
 }
 
 func TestApplyScheduledChange(t *testing.T) {
+	t.Parallel()
+
 	keyring, err := keystore.NewSr25519Keyring()
 	require.NoError(t, err)
 

dot/sync/chain_processor_test.go

@@ -217,7 +217,9 @@ func Test_chainProcessor_handleBody(t *testing.T) {
 	testBody := types.NewBody(testExtrinsics)
 
 	t.Run("base case", func(t *testing.T) {
+		t.Parallel()
 		ctrl := gomock.NewController(t)
+
 		mockTransactionState := NewMockTransactionState(ctrl)
 		mockTransactionState.EXPECT().RemoveExtrinsic(testExtrinsics[0])
 		mockTransactionState.EXPECT().RemoveExtrinsic(testExtrinsics[1])

dot/sync/chain_sync.go

@@ -477,7 +477,7 @@ func (cs *chainSync) handleResult(resultWorker *worker) error {
 	// handle results from worker
 	// if there is an error, potentially retry the worker
 	if resultWorker.err == nil || resultWorker.ctx.Err() != nil {
-		return nil
+		return nil //nolint:nilerr
 	}
 
 	logger.Debugf("worker id %d failed: %s", resultWorker.id, resultWorker.err.err)

internal/pprof/server_test.go

@@ -5,7 +5,7 @@ package pprof
 
 import (
 	"context"
-	"io/ioutil"
+	"io"
 	"net/http"
 	"testing"
 	"time"
@@ -63,9 +63,10 @@ func Test_Server(t *testing.T) {
 	}
 
 	type httpResult struct {
-		url      string
-		response *http.Response
-		err      error
+		url    string
+		status int
+		body   []byte
+		err    error
 	}
 	results := make(chan httpResult)
 
@@ -76,28 +77,37 @@ func Test_Server(t *testing.T) {
 		require.NoError(t, err)
 
 		go func(client *http.Client, request *http.Request, results chan<- httpResult) {
-			response, err := client.Do(request)
-			results <- httpResult{
-				url:      request.URL.String(),
-				response: response,
-				err:      err,
+			result := httpResult{
+				url: request.URL.String(),
 			}
+			var response *http.Response
+			response, result.err = client.Do(request)
+			if result.err != nil {
+				results <- result
+				return
+			}
+
+			result.status = response.StatusCode
+			result.body, result.err = io.ReadAll(response.Body)
+			if result.err != nil {
+				_ = response.Body.Close()
+				results <- result
+				return
+			}
+
+			result.err = response.Body.Close()
+			results <- result
 		}(httpClient, request, results)
 	}
 
 	for range pathsToCheck {
 		httpResult := <-results
 
 		require.NoErrorf(t, httpResult.err, "unexpected error for URL %s: %s", httpResult.url, httpResult.err)
-		assert.Equalf(t, http.StatusOK, httpResult.response.StatusCode,
-			"unexpected status code for URL %s: %s", httpResult.url, http.StatusText(httpResult.response.StatusCode))
-
-		b, err := ioutil.ReadAll(httpResult.response.Body)
-		require.NoErrorf(t, err, "unexpected error for URL %s: %s", httpResult.url, err)
-		assert.NotEmptyf(t, b, "response body is empty for URL %s", httpResult.url)
+		assert.Equalf(t, http.StatusOK, httpResult.status,
+			"unexpected status code for URL %s: %s", httpResult.url, http.StatusText(httpResult.status))
 
-		err = httpResult.response.Body.Close()
-		assert.NoErrorf(t, err, "unexpected error for URL %s: %s", httpResult.url, err)
+		assert.NotEmptyf(t, httpResult.body, "response body is empty for URL %s", httpResult.url)
 	}
 
 	cancel()

internal/trie/node/header_test.go

@@ -16,6 +16,8 @@ import (
 )
 
 func Test_encodeHeader(t *testing.T) {
+	t.Parallel()
+
 	testCases := map[string]struct {
 		node       *Node
 		writes     []writeCall
@@ -275,6 +277,8 @@ func Test_encodeHeader_At_Maximum(t *testing.T) {
 }
 
 func Test_decodeHeader(t *testing.T) {
+	t.Parallel()
+
 	testCases := map[string]struct {
 		reads            []readCall
 		variant          byte

lib/grandpa/message_handler_test.go

@@ -1252,6 +1252,8 @@ func signFakeFullVote(
 }
 
 func TestService_VerifyBlockJustification(t *testing.T) {
+	t.Parallel()
+
 	precommits := buildTestJustification(t, 2, 1, 0, kr, precommit)
 	justification := newJustification(1, testHash, 1, precommits)
 	justificationBytes, err := scale.Marshal(*justification)