Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove all usage of sync.Map #2281

Open
qdm12 opened this issue Feb 9, 2022 · 0 comments
Open

Remove all usage of sync.Map #2281

qdm12 opened this issue Feb 9, 2022 · 0 comments
Labels
Epic Issue used to track development status of a complex feature, aggregates several issues

Comments

@qdm12
Copy link
Contributor

qdm12 commented Feb 9, 2022

sync.Map proved troublesome since it would not be clearing deleted tries.
It was rather hard to debunk when doing #1973 even with various profiling.
This may not bring an advantage memory usage-wise, but could also be one / the main cause of our memory problems.
Anyway, it would be good to remove this doubt.
We should remove all usages of it (except when heavily read and no deletion) and use a mutex protected standard map instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Epic Issue used to track development status of a complex feature, aggregates several issues
Projects
None yet
Development

No branches or pull requests

3 participants