chore(dot/network): replace sync.Map with map+mutex

[qdm12]

Changes

• Add peersData struct holding 3 mutex protected maps:
  • inbound
  • outbound
  • mutexes
• Add helping methods on peersData:
  • countOutboundStreams
  • countInboundStreams

Tests

Issues

• Remove all usage of sync.Map #2281

Primary Reviewer

[codecov]

Codecov Report

Merging #2284 (fc4c75c) into development (2086496) will increase coverage by 2.01%.
The diff coverage is 76.76%.

❗ Current head fc4c75c differs from pull request most recent head 90b9572. Consider uploading reports for the commit 90b9572 to get more accurate results

@@               Coverage Diff               @@
##           development    #2284      +/-   ##
===============================================
+ Coverage        58.04%   60.05%   +2.01%     
===============================================
  Files              213      212       -1     
  Lines            27992    27779     -213     
===============================================
+ Hits             16247    16683     +436     
+ Misses           10109     9370     -739     
- Partials          1636     1726      +90     

Flag	Coverage Δ
unit-tests	60.05% <76.76%> (+2.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
dot/network/service.go	57.30% <50.00%> (+1.42%)	⬆️
dot/network/peersdata.go	72.41% <72.41%> (ø)
dot/network/notifications.go	68.26% <89.65%> (-1.33%)	⬇️
dot/network/block_announce.go	59.32% <100.00%> (-5.09%)	⬇️
dot/network/inbound.go	92.98% <100.00%> (-7.02%)	⬇️
dot/core/service.go	0.00% <0.00%> (-33.51%)	⬇️
dot/state/block_notify.go	81.90% <0.00%> (-8.58%)	⬇️
dot/types/header.go	70.68% <0.00%> (-4.32%)	⬇️
... and 64 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2086496...90b9572. Read the comment docs.

[noot]

looks good, minor comment only